Move workflow update polling inside of interceptor #2159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sushisource
commented
Jul 30, 2024
Comment on lines
+116
to
+117
| public <R> UpdateHandle<R> startUpdate(StartUpdateInput<R> input) { | ||
| super.startUpdate(input); |
There was a problem hiding this comment.
Side note: Why don't we have something like InputType.fromExisting(input) and then some way to relatively easily modify the input? It's a bit annoying to have to re-pass every field through to a new constructor if you want to modify inputs.
I get why they're not directly mutable, but, might be nice to have a convenient way to do that.
There was a problem hiding this comment.
Modify inputs is not really an encouraged pattern. Not that some users don't but I it is a advanced path to take.
| @@ -119,7 +120,7 @@ public <R> QueryOutput<R> query(QueryInput<R> input) { | |||
| } | |||
|
|
|||
| @Override | |||
| public <R> StartUpdateOutput<R> startUpdate(StartUpdateInput<R> input) { | |||
| public <R> UpdateHandle<R> startUpdate(StartUpdateInput<R> input) { | |||
There was a problem hiding this comment.
Hm I wonder if we would ever need to return more then UpdateHandle here? I think other SDKs just return UpdateHandle so if we do will have to address in all SDKs
Sushisource
force-pushed
the
move-update-poll-inside-interceptor
branch
from
7405311 to
1cb3b82
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Moved update polling to be inside of the interceptor a-la other SDKs
Why?
Consistent, allows interceptor to change things post-polling
Checklist
Closes Java SDK
StartUpdatewaits outside of intercepted call #2094How was this tested:
Added an integ test using the interceptor
Any docs updates needed?