Revert configurable slot provider #2134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 8a2d5cd.
Quinn-With-Two-Ns
force-pushed
the
revert-configurable-slot-provider
branch
from
fec16f9 to
d967326
Compare
cretz
approved these changes
Jul 8, 2024
Sushisource
added a commit
to Sushisource/sdk-java
that referenced
this pull request
Jul 10, 2024
This reverts commit 46b239d.
Sushisource
added a commit
to Sushisource/sdk-java
that referenced
this pull request
Jul 17, 2024
This reverts commit 46b239d.
Sushisource
added a commit
to Sushisource/sdk-java
that referenced
this pull request
Jul 19, 2024
This reverts commit 46b239d.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert configurable slot provider changes because it is causing multiple regressions with slot metrics and local activities.
Note for reviewers, the first two commits are the revert and this adds a test that would have caught these issues.