Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue with isReplaying causing direct query to spam logs #2087

Merged
merged 3 commits into from
May 31, 2024
Merged

Fix issue with isReplaying causing direct query to spam logs #2087

merged 3 commits into from
May 31, 2024

Conversation

Quinn-With-Two-Ns
Copy link
Contributor

Fix issue with isReplaying causing direct query to spam logs. When we are grouping events there is an edge case where the last event is also ending a workflow task.

closes #2076

@Quinn-With-Two-Ns Quinn-With-Two-Ns requested a review from a team as a code owner May 31, 2024 16:32
@Quinn-With-Two-Ns Quinn-With-Two-Ns merged commit 5c464e8 into temporalio:master May 31, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sushisource Sushisource Sushisource approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Querying a running workflow makes it spam previously logged messages
2 participants
@Quinn-With-Two-Ns @Sushisource