SpringBoot - Add registered workflow and activity impl info to workers template #1986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tihomir Surdilovic <[email protected]>
|
Sample screenshot: 
|
tsurdilo
changed the title
tsurdilo
changed the title
| return this; | ||
| } | ||
|
|
||
| public List<String> getRegisteredActivityInfo() { |
There was a problem hiding this comment.
Do you think there is other information users may want us to expose in the future about activities or workflows other then their name?
There was a problem hiding this comment.
May make sense to return a list of objects so we can add new fields if decided to expose more info.
There was a problem hiding this comment.
ok good point, will update
...gure-alpha/src/main/java/io/temporal/spring/boot/autoconfigure/template/WorkersTemplate.java
Show resolved
Hide resolved
Signed-off-by: Tihomir Surdilovic <[email protected]>
Signed-off-by: Tihomir Surdilovic <[email protected]>
|
@Quinn-With-Two-Ns made updates, let me know if ok now |
Quinn-With-Two-Ns
approved these changes
Feb 16, 2024
Quinn-With-Two-Ns
requested changes
Feb 16, 2024
Signed-off-by: Tihomir Surdilovic <[email protected]>
|
Added Experimental flag to getRegisteredInfo method |
Quinn-With-Two-Ns
approved these changes
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to WorkersTemplate to expose registered workflow and activity class info per task queue.
Allows users to build custom actuator endpoints that display this.
Sample that uses this info to create a custom actuator endpoint temporalio/samples-java#576