Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change the default behavior of retries in WorkflowExecutionUtils#getInstanceCloseEvent #651

Closed
Spikhalskiy opened this issue Aug 19, 2021 · 0 comments · Fixed by #667
Closed

Change the default behavior of retries in WorkflowExecutionUtils#getInstanceCloseEvent #651

Spikhalskiy opened this issue Aug 19, 2021 · 0 comments · Fixed by #667
Assignees
@Spikhalskiy
Labels
enhancement User experience
Milestone
v1.3.0

Comments

@Spikhalskiy
Copy link
Contributor

Spikhalskiy commented Aug 19, 2021 •
edited
Loading

We have no exponential backoff on WorkflowExecutionUtils#getInstanceCloseEvent and we should add it to avoid clients hammering the server in case of server/network outage.

Proposal:
add backoffCoefficient
set maximumInterval into a reasonable value to limit the backoff
implement #652 to allow users who are using workflow stub proxies to pass reasonable timeout into WorkflowExecutionUtils#getInstanceCloseEvent
@Spikhalskiy Spikhalskiy added enhancement User experience TBD labels Aug 19, 2021
@Spikhalskiy Spikhalskiy added this to the v1.3.0 milestone Aug 23, 2021
@Spikhalskiy Spikhalskiy removed the TBD label Aug 24, 2021
@Spikhalskiy Spikhalskiy mentioned this issue Aug 24, 2021
Merged
Spikhalskiy added a commit to Spikhalskiy/java-sdk that referenced this issue Aug 25, 2021
@Spikhalskiy
Add backoff to WorkflowExecutionUtils#getInstanceCloseEvent
d52ddbb 
Update some options of DefaultStubServiceOperationRpcRetryOptions to be close to Go SDK behavior
Issue temporalio#651
@Spikhalskiy Spikhalskiy mentioned this issue Aug 25, 2021
Merged
Spikhalskiy added a commit to Spikhalskiy/java-sdk that referenced this issue Aug 26, 2021
@Spikhalskiy
Add backoff to WorkflowExecutionUtils#getInstanceCloseEvent
be23e23 
Update some options of DefaultStubServiceOperationRpcRetryOptions to be close to Go SDK behavior
Issue temporalio#651
Spikhalskiy added a commit that referenced this issue Aug 26, 2021
@Spikhalskiy
Add backoff to WorkflowExecutionUtils#getInstanceCloseEvent (#667)
6d55180 
Update some options of DefaultStubServiceOperationRpcRetryOptions to be close to Go SDK behavior
Issue #651
@Spikhalskiy Spikhalskiy self-assigned this Aug 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Spikhalskiy Spikhalskiy

Labels
enhancement User experience
Projects
None yet
Milestone
v1.3.0
Development

Successfully merging a pull request may close this issue.

Add backoff to WorkflowExecutionUtils#getInstanceCloseEvent Spikhalskiy/java-sdk
1 participant
@Spikhalskiy