Make remoteDataConverter implement PayloadCodec #1303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
|
I wonder if it'd be clearer to just have a |
dandavison
force-pushed
the
remote-payload-codec
branch
from
d40bf88 to
73b459a
Compare
dandavison
force-pushed
the
remote-payload-codec
branch
2 times, most recently
from
bf7aeb2 to
5d36436
Compare
cretz
reviewed
Dec 4, 2023
dandavison
force-pushed
the
remote-payload-codec
branch
from
c039b54 to
095cbce
Compare
cretz
approved these changes
Dec 4, 2023
Quinn-With-Two-Ns
approved these changes
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
remoteDataConverterinto separatePayloadCodecandDataConverterWhy?
temporalCLI: Use gRPC interceptor instead of data converter for encoding/decoding cli#384Checklist
How was this tested: Use gRPC interceptor instead of data converter for encoding/decoding cli#384
Any docs updates needed?
No. The change is backwards compatible.