[WORK IN PROGRESS] Add DSL Sample #47

darewreck54 · 2020-09-27T17:47:46Z

Add a dsl example. This is to port the Go Example.

There were issue with the previous #45, so created a new one.

darewreck54 · 2020-09-27T17:48:44Z

src/main/java/io/temporal/samples/dsl/models/Statement.java

+public class Statement {
+  public ActivityInvocation activity;
+  public Sequence sequence;
+  public Parrallel parrallel;


@mfateev You made a comment about using inheritance. Can you give me an example of what you mean? I wasn't following what can inherit from what?

interface Statement {}
class Sequence implements Statement {}
class ActivityInvocation implements Statement {}
class Parallel implements Statement {}

I'm not seeing what the interface could be. Here is wha we have?

class Statement { public ActivityInvocation activity; public Sequence sequence; public Parallel parallel; } class Sequence { public Statement elements[]; } class Parallel { public Statement branches[]; } class ActivityInvocation { public String name; public String method; public String[] arguments; public String result; }

The only thing similar is sequence and parallel, but you would have to change the name to be consistent elements vs. branches.

@mfateev ping

src/main/resources/dsl/workflow1.yaml

src/main/java/io/temporal/samples/dsl/models/ActivityInvocation.java

darewreck54 · 2020-09-27T17:53:14Z

@mfateev I addressed the comments that I understood and added questions in the code. If you have time, please take a look and let me know how I can proceed.

Thanks!

mfateev

Thanks a lot for the contribution!

mfateev · 2020-09-27T19:54:34Z

src/main/java/io/temporal/samples/dsl/SampleActivities.java

+import io.temporal.activity.ActivityInterface;
+import io.temporal.activity.ActivityMethod;
+
+public class SampleActivities {


For simplicity let's use a single activity interface with multiple methods instead of many interfaces.

I think leaving as it shows the user how you would use the name_interface in the case a user wants to go with that approach (ex. I wanted to know and it wasn't clear to me). But if you want me to change it, let me know.

Yes, I would change it. We can create another example that demonstrates multiple Activity interfaces.

src/main/java/io/temporal/samples/dsl/models/ActivityInvocation.java

mfateev · 2020-09-27T20:00:12Z

src/main/java/io/temporal/samples/dsl/models/ActivityInvocation.java

+                .setTaskQueue("dsl")
+                .build());
+
+    String results = stub.execute(this.method, String.class, new Object[] {args});


It would be nice to change activities to accept the args as the current implementation doesn't use them at all.
I'm not sure why new Object[] {args} is needed instead of just args.

If you don't do this, you get a warning in java. The method takes a list of args which need to be expanded. This was the workaround I found on stack-overflow to get around it.

It would be nice to change activities to accept the args as the current implementation doesn't use them at all.

Doesn't passing in the args like that use it in the activities? When I look at the stack trace, it looks like it's using it as inputs in the payload. Were you referring to something else?

src/main/java/io/temporal/samples/dsl/models/Parrallel.java

mfateev · 2020-09-27T20:02:56Z

src/main/java/io/temporal/samples/dsl/models/Statement.java

+public class Statement {
+  public ActivityInvocation activity;
+  public Sequence sequence;
+  public Parrallel parrallel;


interface Statement {}
class Sequence implements Statement {}
class ActivityInvocation implements Statement {}
class Parallel implements Statement {}

src/main/java/io/temporal/samples/dsl/models/Workflow.java

src/main/resources/dsl/workflow1.yaml

mfateev · 2020-11-01T01:14:39Z

src/main/java/io/temporal/samples/dsl/SampleActivities.java

+import io.temporal.activity.ActivityInterface;
+import io.temporal.activity.ActivityMethod;
+
+public class SampleActivities {


Yes, I would change it. We can create another example that demonstrates multiple Activity interfaces.

mfateev · 2020-11-01T01:16:45Z

src/main/java/io/temporal/samples/dsl/models/ActivityInvocation.java

@@ -36,7 +36,9 @@ public Void execute(Map<String, String> bindings) {
                .setTaskQueue("dsl")
                .build());

-    String results = stub.execute(this.method, String.class, new Object[] {args});
+    String methodNameDescriptor =
+        this.name + this.method.substring(0, 1).toUpperCase() + this.method.substring(1);


I would use a single "activityType" string. Activities can be implemented in different languages like Go which have completely different approach to activity naming.

flossypurse · 2021-06-20T13:57:28Z

src/main/java/io/temporal/samples/dsl/models/Parallel.java

+
+  public void execute(Map<String, String> bindings) {
+    // In the parallel block, we want to execute all of them in parallel and wait for all of them.
+    // if one activity fails then we want to cancel all the rest of them as well.


Suggested change

// if one activity fails then we want to cancel all the rest of them as well.

// if one Activity Execution fails then we want to cancel all the rest of them as well.

tsurdilo · 2021-07-07T21:23:03Z

This sample is fairly outdated and we are working on a new DSL example. I will close this for now and if there is any more inputs/additions you would like to add here please feel free to reopen it.

darewreck54 · 2021-07-07T21:25:53Z

@tsurdilo Sorry, i've been busy so I haven't had time to update this. Would you like me to push the changes or do you think its not needed since it sounds like you have a new DSL example?

Also mind if i see what your new DSL example looks like?

tsurdilo · 2021-07-07T21:32:35Z

@darewreck54 up to you I can reopen this again, np :)
I don't have the PR ready yet, it's using DynamicWorkflow and DynamicInterface. Will ping you when its ready for review.

tsurdilo · 2021-09-09T01:13:05Z

@darewreck54 created #151
will close this pr. feel free to reopen it if you like. thanks!

DSL Support

fafebce

darewreck54 commented Sep 27, 2020

View reviewed changes

src/main/resources/dsl/workflow1.yaml Outdated Show resolved Hide resolved

darewreck54 commented Sep 27, 2020

View reviewed changes

src/main/java/io/temporal/samples/dsl/models/ActivityInvocation.java Outdated Show resolved Hide resolved

mfateev requested changes Sep 27, 2020

View reviewed changes

darewreck54 added 2 commits September 27, 2020 14:23

Fix naming issue

8951d89

address Pr comments

debdb3b

mfateev requested changes Nov 1, 2020

View reviewed changes

flossypurse reviewed Jun 20, 2021

View reviewed changes

tsurdilo closed this Jul 7, 2021

tsurdilo reopened this Jul 7, 2021

tsurdilo changed the title ~~Feat(DSL Sample): Add DSL Sample~~ [WORK IN PROGRESS] Add DSL Sample Jul 7, 2021

tsurdilo closed this Sep 9, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[WORK IN PROGRESS] Add DSL Sample #47

[WORK IN PROGRESS] Add DSL Sample #47

darewreck54 commented Sep 27, 2020

darewreck54 Sep 27, 2020

mfateev Sep 27, 2020

darewreck54 Sep 28, 2020

darewreck54 Sep 30, 2020

darewreck54 commented Sep 27, 2020

mfateev left a comment

mfateev Sep 27, 2020

darewreck54 Sep 28, 2020

mfateev Nov 1, 2020

mfateev Sep 27, 2020

darewreck54 Sep 27, 2020

mfateev Sep 27, 2020

mfateev Nov 1, 2020

mfateev Nov 1, 2020

flossypurse Jun 20, 2021

tsurdilo commented Jul 7, 2021

darewreck54 commented Jul 7, 2021

tsurdilo commented Jul 7, 2021

tsurdilo commented Sep 9, 2021

	// if one activity fails then we want to cancel all the rest of them as well.
	// if one Activity Execution fails then we want to cancel all the rest of them as well.

[WORK IN PROGRESS] Add DSL Sample #47

[WORK IN PROGRESS] Add DSL Sample #47

Conversation

darewreck54 commented Sep 27, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

darewreck54 commented Sep 27, 2020

mfateev left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tsurdilo commented Jul 7, 2021

darewreck54 commented Jul 7, 2021

tsurdilo commented Jul 7, 2021

tsurdilo commented Sep 9, 2021