Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: support API Keys #575

Merged
merged 7 commits into from
Nov 10, 2024
Merged

feature: support API Keys #575

merged 7 commits into from
Nov 10, 2024

Conversation

rustatian
Copy link
Collaborator

@rustatian rustatian commented Oct 30, 2024

Reason for This PR

  • API Key public preview support. docs.

Description of Changes

  • Support dynamically changing API keys.
  • API key can be set by the PHP worker and updated by using UpdateAPIKey RR<->PHP RPC API.

Token can be initially set via the internal WokerInfo IPC call (flags field, ApiKey key inside the associated array) and updated via UpdateAPIKey RPC call where the first argument is a string, the second - bool (true - token changed, false - new token was empty).

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the MIT license.

PR Checklist

[Author TODO: Meet these criteria.]
[Reviewer TODO: Verify that these criteria are met. Request changes if not]

  • All commits in this PR are signed (git commit -s).
  • The reason for this PR is clearly provided (issue no. or explanation).
  • The description of changes is clear and encompassing.
  • Any required documentation changes (code and docs) are included in this PR.
  • Any user-facing changes are mentioned in CHANGELOG.md.
  • All added/changed functionality is tested.

Signed-off-by: Valery Piashchynski <[email protected]>
@rustatian rustatian added the C-feature-request Category: feature requested, but need to be discussed label Oct 30, 2024
@rustatian rustatian requested a review from wolfy-j October 30, 2024 21:36
@rustatian rustatian self-assigned this Oct 30, 2024
Signed-off-by: Valery Piashchynski <[email protected]>
@rustatian rustatian merged commit 243b8c0 into master Nov 10, 2024
8 checks passed
@rustatian rustatian deleted the feature/api-key-support branch November 10, 2024 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-feature-request Category: feature requested, but need to be discussed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants