Skip to content
This repository has been archived by the owner on Oct 9, 2024. It is now read-only.

Add GitHub Actions build for publishing container image #30

Merged
merged 1 commit into from
Aug 19, 2021
Merged

Add GitHub Actions build for publishing container image #30

merged 1 commit into from
Aug 19, 2021

Conversation

sagikazarmark
Copy link
Contributor

@sagikazarmark sagikazarmark commented Aug 18, 2021

Signed-off-by: Mark Sagi-Kazar [email protected]

What was changed

Added GitHub Actions build for publishing container image

Why?

See #26

Checklist

  1. Closes Publish an official Docker image #26

  2. How was this tested:
    Testing is a bit problematic, because it won't run, until merged, but I use this workflow in a lot of projects.

  3. Any docs updates needed?
    None

@CLAassistant
Copy link

CLAassistant commented Aug 18, 2021

CLA assistant check
All committers have signed the CLA.

@sagikazarmark sagikazarmark marked this pull request as ready for review August 18, 2021 10:03
Copy link
Collaborator

@mikhailshilkov mikhailshilkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, let's try this out

@mikhailshilkov mikhailshilkov merged commit 1c5eb6e into temporalio:master Aug 19, 2021
@sagikazarmark sagikazarmark deleted the publish-docker-image branch August 19, 2021 08:07
@sagikazarmark
Copy link
Contributor Author

Seems to be working. If you tag a new version, it should publish that tag as well. But make sure the tag matches the pattern used in the Actions workflow (vX.Y.Z) (or modify the workflow of course).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Publish an official Docker image
3 participants