Fix flaky reset test #713
Merged
Fix flaky reset test #713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dandavison
commented
Nov 21, 2024
| }) | ||
| s.NoError(err) | ||
| return len(resp.Executions) > 0 | ||
| }, 3*time.Second, 100*time.Millisecond, "Workflow failed to start") |
There was a problem hiding this comment.
This code was waiting for the workflow to exist, whereas we needed to wait for the workflow task to be complete.
dandavison
force-pushed
the
fix-reset-test
branch
from
e7d70f3 to
16a888b
Compare
josh-berry
approved these changes
Nov 21, 2024
cretz
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a flaky test from #700
Prior to this commit, failures were fairly frequent, e.g. to reproduce: