Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Makefile #665

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove Makefile #665

wants to merge 1 commit into from

Conversation

cretz
Copy link
Member

@cretz cretz commented Sep 13, 2024

What was changed

To be consistent with other SDK repos, remove Makefile that was added in an unrelated PR at #561. May be reintroduced, but should at least get wider consensus and be called in CI to confirm it even works.

@cretz cretz requested a review from a team September 13, 2024 13:37
Copy link
Contributor

@dandavison dandavison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find the Makefile helpful, and so I view it as an incremental step, potentially in a desirable direction, rather than as a violation of a previously existing policy. So that suggests discussion before removal.

@josh-berry
Copy link
Collaborator

I have not forgotten about this.

If we remove it, I would like to replace it with something platform-independent and standardized (as much as possible in the Go ecosystem anyway) that accomplishes the same goal. Otherwise I think having it (and maybe adding a script for Windows folks) is better than nothing.

@cretz
Copy link
Member Author

cretz commented Sep 23, 2024

If we remove it, I would like to replace it with something platform-independent and standardized (as much as possible in the Go ecosystem anyway) that accomplishes the same goal

This exists and is called go build and go run and was the accepted cross-platform method of working with the CLI until this Makefile got added in an unrelated PR sans discussion (compared to this PR which is getting discussion).

@josh-berry
Copy link
Collaborator

This exists and is called go build and go run

Dan and I have both explained why this is not the same thing as the Makefile--you might want to review that Slack discussion. If you need a pointer to it, poke me separately and I'll find it again for you.

@cretz
Copy link
Member Author

cretz commented Sep 23, 2024

👍 Definitely understood it's not the same thing as a Makefile, on purpose, it's better, consistent, more cross-platform, etc. There was a CLI way, this secretly changed, and looks like it's not going back.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants