-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add --public-path option to the command #644
Conversation
|
This LGTM. I think you'll have to sign the CLA before we can merge. |
done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Approved and will wait for @josh-berry's approval. I may also confirm internally with our frontend team that there are no gotchas here with setting this value.
1437f7c
to
1d951b1
Compare
Thanks! |
It’s up to me to thank you! Is it possible to tell us when this PR will be available in the |
add an option in the cli to configure the public path for the UI in dev mode
What was changed
add
--public-path
option to the commandWhy?
/q/temporal
)Checklist
Closes
How was this tested: