Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add --public-path option to the command #644

Merged
merged 1 commit into from
Aug 23, 2024
Merged

Conversation

ggrebert
Copy link
Contributor

add an option in the cli to configure the public path for the UI in dev mode

What was changed

add --public-path option to the command

Why?

  • creating a quarkus extension for temporal
  • add an easy way to proxify the temporal devservice (/q/temporal)

Checklist

  1. Closes

  2. How was this tested:

  1. Any docs updates needed?

@CLAassistant
Copy link

CLAassistant commented Aug 22, 2024

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@cretz
Copy link
Member

cretz commented Aug 22, 2024

This LGTM. I think you'll have to sign the CLA before we can merge.

@ggrebert
Copy link
Contributor Author

This LGTM. I think you'll have to sign the CLA before we can merge.

done

Copy link
Member

@cretz cretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Approved and will wait for @josh-berry's approval. I may also confirm internally with our frontend team that there are no gotchas here with setting this value.

temporalcli/commands.gen.go Outdated Show resolved Hide resolved
@ggrebert ggrebert force-pushed the public-path branch 2 times, most recently from 1437f7c to 1d951b1 Compare August 23, 2024 15:36
@cretz cretz merged commit f46c45c into temporalio:main Aug 23, 2024
7 checks passed
@cretz
Copy link
Member

cretz commented Aug 23, 2024

Thanks!

@ggrebert
Copy link
Contributor Author

ggrebert commented Aug 23, 2024

It’s up to me to thank you!

Is it possible to tell us when this PR will be available in the temporalio/auto-setup Docker image ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants