Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update UI module for versioning pre-release #614

Merged
merged 3 commits into from
Jul 3, 2024
Merged

Update UI module for versioning pre-release #614

merged 3 commits into from
Jul 3, 2024

Conversation

antlai-temporal
Copy link
Contributor

What was changed

Update UI dependency.

Why?

Needed for versioning pre-release.

cretz
cretz approved these changes Jul 3, 2024
View reviewed changes
Copy link
Member

@cretz cretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't have a great end-to-end testing story for dev server UI. Just want to make sure we have at least confirmed it works manually clicking around the UI.

@antlai-temporal
Copy link
Contributor Author

We don't have a great end-to-end testing story for dev server UI. Just want to make sure we have at least confirmed it works
manually clicking around the UI.
I did start the server, created a workflow, got the UI showing history, Build ID for workers, and so on...

@antlai-temporal antlai-temporal merged commit f51e0d5 into temporalio:main Jul 3, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cretz cretz cretz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antlai-temporal @cretz