Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix panic when started without a stdout #549

Merged
merged 5 commits into from
May 14, 2024

Conversation

mjameswh
Copy link
Contributor

@mjameswh mjameswh commented May 2, 2024

What was changed

  • Don't panic in Printer if no stdout

Why?

@CLAassistant
Copy link

CLAassistant commented May 2, 2024

CLA assistant check
All committers have signed the CLA.

@mjameswh mjameswh requested a review from cretz May 2, 2024 18:45
temporalcli/internal/printer/printer.go Outdated Show resolved Hide resolved
temporalcli/internal/printer/printer.go Outdated Show resolved Hide resolved
temporalcli/internal/printer/printer.go Outdated Show resolved Hide resolved
@mjameswh mjameswh force-pushed the fix-panic-on-stdout-closed branch from 755e605 to 4f9a741 Compare May 13, 2024 16:56
mjameswh

This comment was marked as off-topic.

@mjameswh mjameswh requested a review from cretz May 13, 2024 21:04
@mjameswh mjameswh merged commit 0160df0 into temporalio:main May 14, 2024
6 of 7 checks passed
@mjameswh mjameswh deleted the fix-panic-on-stdout-closed branch May 14, 2024 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] CLI panics if started without a stdout file descriptor
3 participants