Add temporal workflow fix-history-json subcommand.
#504
Conversation
|
|
| } | ||
|
|
||
| default: | ||
| err = os.WriteFile(c.TargetFile, raw, 0o666) |
There was a problem hiding this comment.
| err = os.WriteFile(c.TargetFile, raw, 0o666) | |
| return os.WriteFile(c.TargetFile, raw, 0600) |
o not needed (0 prefix assumes octal), but can leave in if it reads better for you. Also, technically history can have some private data, wonder if we want owner-only.
There was a problem hiding this comment.
I prefer 0o because I think it's what C should have used for octal all along.
As for 666 vs 600, I'm always a little cautious about overruling the user's umask, but if you think it's reasonable here (when temporal workflow show -o json > file.json would just use the umask) we can do that.
There was a problem hiding this comment.
Works for me, I think what you have here is fine
| @@ -635,6 +635,21 @@ temporal workflow execute | |||
| Includes options set for [workflow start](#options-set-for-workflow-start). | |||
| Includes options set for [payload input](#options-set-for-payload-input). | |||
|
|
|||
| ### temporal workflow fix-history-json: Updates an event history JSON file to the current format. | |||
There was a problem hiding this comment.
I like this naming. I hope we can remove it one day, heh.
| } | ||
|
|
||
| default: | ||
| err = os.WriteFile(c.TargetFile, raw, 0o666) |
There was a problem hiding this comment.
Works for me, I think what you have here is fine
chronos-tachyon
changed the title
temporal workflow history convert subcommand.temporal workflow fix-history-json subcommand.
What was changed
temporal workflow fix-history-jsonWhy?
This command reads an event history JSON object using the
client.HistoryFromJSONAPI, then serializes it back out using theprotojsonAPI.HistoryFromJSONis backward compatible with both the standard protobuf JSON format and with GoGoProto's format, which differ in their handling of enum values.Checklist
Closes internal JIRA tickets SDK-1570 and OSS-1658, which do not seem to have equivalent issues in the public GitHub.
How was this tested:
I downloaded a sample event history JSON from my dev server, then ran it through a few conversions.
Any docs updates needed?
If there's a manual step in publishing changes to
commands.md, then it will need to be run.