Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding task-queue list-partition command #491

Merged
merged 5 commits into from
Mar 6, 2024

Conversation

prathyushpv
Copy link
Contributor

What was changed

Adding task-queue list-partition command

Breaking changes

  • This command had --output option which can take values table, card and json. We will not have card and table options. Option text will print a table view.
  • --output json was printing some text line in current cli. Here we will print response object without that.

Why?

cli rewrite

Checklist

@prathyushpv prathyushpv changed the base branch from main to cli-rewrite March 6, 2024 02:53
@prathyushpv prathyushpv marked this pull request as ready for review March 6, 2024 02:59
@prathyushpv prathyushpv requested a review from cretz March 6, 2024 15:47
Copy link
Member

@cretz cretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just one minor change wrt spacing on the markdown, but it's not technically required because we trim during parse.

temporalcli/commands.taskqueue.go Outdated Show resolved Hide resolved
temporalcli/commandsmd/commands.md Outdated Show resolved Hide resolved
@prathyushpv
Copy link
Contributor Author

Thanks @cretz !

@prathyushpv prathyushpv merged commit 3de277f into cli-rewrite Mar 6, 2024
4 checks passed
@prathyushpv prathyushpv deleted the ppv/list-partition branch March 6, 2024 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants