Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI Refresh: workflow update command #462

Merged
merged 2 commits into from
Feb 15, 2024

Conversation

pdoerner
Copy link
Contributor

What was changed

Add support for workflow update command. The functionality should be unchanged but the output may be different.

@pdoerner pdoerner changed the title CLI Refresh: workflow signal command CLI Refresh: workflow update command Feb 15, 2024
@pdoerner pdoerner requested a review from cretz February 15, 2024 19:06
Copy link
Member

@cretz cretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Merge at will

return fmt.Errorf("unable to update workflow: %w", err)
}

var valuePtr interface{}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think elsewhere I did:

Suggested change
var valuePtr interface{}
var valuePtr json.RawMessage

Though I think it's basically the same thing here (it'll just be a map[string]any for an object which is turned right back to JSON) so no worries.

@pdoerner pdoerner merged commit 3f61147 into cli-rewrite Feb 15, 2024
5 checks passed
@pdoerner pdoerner deleted the cli-rewrite-workflow-update branch February 15, 2024 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants