Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add first_execution_run_id to missing requests and responses #151

Closed
wants to merge 1 commit into from

Conversation

bergundy
Copy link
Member

As discussed on slack, we need first_execution_run_id in all of these requests to make them safer.
Also added this to SignalWithStartWorkflowExecutionResponse to make using stubs / handles created this way safer.

@bergundy bergundy requested review from cretz and yiminc February 11, 2022 22:48
Copy link
Member

@cretz cretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Would rather not merge this until we get the server impl at least POC'd to confirm no more changes/quirks are needed. Rollbacks and backwards-incompatible changes in this repo are a bit rough.

@bergundy
Copy link
Member Author

We could probably add first_execution_request_id to GetWorkflowExecutionHistoryRequest too. It would be more efficient because we could start from the last run instead of iterating through all runs.

Comment on lines +522 to +524
// If set, this call will error if the most recent (if no run id is set on
// `workflow_execution`), or specified (if it is) workflow execution is not part of the same
// execution chain as this id.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found this comment hard to read. Better to break it into 2 sentences. For example:
If set, this call will error if the target workflow is not part of the same execution chain as this id. Target workflow is specified by workflow_execution if run_id is set there, or the most recent run if run_id is not set on workflow_execution.

Copy link

@macrogreg macrogreg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR only addresses a part of the "workflow chain overflow" scenario.
I think we need to hold off on merging it and instead address it holistically with the part of returning the "workflow chain IDs" back to the user.

See here for details: temporalio/temporal#2691

@bergundy
Copy link
Member Author

Yes, I agree @macrogreg.
I didn't want to merge this before verifying the server can implement these API changes anyways.
Let's see if we can get this prioritized.

@bergundy
Copy link
Member Author

We're not doing this anytime soon.

@bergundy bergundy closed this Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants