Make sure the export package is visitable #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cretz
approved these changes
Aug 16, 2024
proxy/interceptor_test.go
Outdated
Comment on lines
30
to
31
| "go.temporal.io/api/export/v1" | ||
| "go.temporal.io/api/history/v1" |
There was a problem hiding this comment.
Go fmt I would expect would fix this to move non-stdlib imports to later, but no biggie
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Go version auto-updated itself, seemingly because of dependencies.
What changed?
Add the top level type of the export package to the visit walking mechanics
Why?
So users can visit payloads on these types
How did you test it?
Upgraded test
Potential risks
Nada
Closes temporalio/sdk-go#1566