cli: Add extension_dependencies metadata #468
Conversation
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
EvanHStanton
changed the title
There was a problem hiding this comment.
@EvanHStanton Awesome work, this looks good! Please see the two follow-up comments I left in the review:
- Extension dependencies should be automatically read from the control file
- Registry side of this PR
| // TODO: If extension_dependencies is none, check for control file and fetch 'requires' field (similar to below) | ||
| // example: https://github.com/paradedb/paradedb/blob/9a0b1601a9c7026e5c89eef51a422b9d284b3058/pg_search/pg_search.control#L6C1-L6C9 | ||
|
|
There was a problem hiding this comment.
@EvanHStanton as a follow-up, we'll want to pull the dependency information from the control file if it exists. The information will then be pulled automatically and we won't need to set extension_dependencies in our toml unless absolutely necessary.
There was a problem hiding this comment.
You'll want to add a test for this as well
| @@ -64,6 +66,7 @@ pub struct Category { | |||
| pub struct PublishSettings { | |||
| name: String, | |||
| extension_name: Option<String>, | |||
| extension_dependencies: Option<Vec<String>>, | |||
There was a problem hiding this comment.
Be sure to follow up with the registry side of this PR, so the registry can accept this new value
No description provided.