Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port to new glib subclassing API #17

Merged
merged 2 commits into from
Dec 12, 2018
Merged

Port to new glib subclassing API #17

merged 2 commits into from
Dec 12, 2018

Conversation

dpeite
Copy link
Contributor

@dpeite dpeite commented Dec 12, 2018

No description provided.

@dpeite dpeite requested a review from rubenrua December 12, 2018 11:06
@dpeite
Copy link
Contributor Author

dpeite commented Dec 12, 2018

You might want to use byte-slice-cast for converting it first to a &[i16] safely and then getting the pointer from that.

You can also only move this #[allow] directive on top of the block where this code lives to not allow it for the whole file :)

Thanks for the tips @sdroege, finally I use byte-slice-cast crate.

😃

@rubenrua rubenrua merged commit 127dbca into master Dec 12, 2018
@rubenrua rubenrua deleted the new_glib_subclassing branch December 12, 2018 11:21
@Lokeshagit Lokeshagit mentioned this pull request Mar 14, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rubenrua rubenrua Awaiting requested review from rubenrua

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dpeite @rubenrua @sdroege