Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Telekom user menu (WIP) #2208

Merged
merged 59 commits into from
Feb 8, 2024
Merged

feat: Telekom user menu (WIP) #2208

merged 59 commits into from
Feb 8, 2024

Conversation

tallence-dsulyok
Copy link
Contributor

No description provided.

@netlify Netlify
Copy link

netlify bot commented Nov 16, 2023 •
edited
Loading

✅ Deploy Preview for marvelous-moxie-a6e2fe ready!

Name Link
🔨 Latest commit 86ba3da
🔍 Latest deploy log https://app.netlify.com/sites/marvelous-moxie-a6e2fe/deploys/65bb732ae8b27d000835e5b4
😎 Deploy Preview https://deploy-preview-2208--marvelous-moxie-a6e2fe.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@tallence-dsulyok
fix: js error when closing menu-flyout
ea542e8
@tallence-dsulyok
removed TODOs
9a81601
@tallence-dsulyok
updated default URLs
16a1a3f
@tallence-dsulyok
cleaned up demo
0c165f7
@tallence-dsulyok
added profile menu demo draft to storybook
7c2c32a
@tallence-dsulyok
storybook: added component
2679c65
@tallence-dsulyok
storybook: added missing attributes
79d169f
@tallence-dsulyok
storybook: added missing attributes
7b28515
@tallence-dsulyok
storybook: added missing attributes
c1e8877
@tallence-dsulyok
default value for serviceLinks
f231523
@tallence-dsulyok
debug service links
321c025
@tallence-dsulyok
debug service links
50a8d5d
@tallence-dsulyok
added a11y labels: close menu, open (mobile) menu
1141c5b
@tallence-dsulyok
added a11y labels: close menu, open (mobile) menu
d2a344c
@tallence-dsulyok
storybook: added argsTable
910209c
@tallence-dsulyok
storybook: added loggedIn-toggle to argsTable
1eab187
@tallence-dsulyok
storybook: added loggedIn-toggle to argsTable
a889694
@tallence-dsulyok
storybook: added loggedIn-toggle to argsTable (undo removing props)
5b840cb
@tallence-dsulyok
storybook: loggedIn default true
8af5dd2
@tallence-dsulyok
storybook: add profile menu as separate story
84113e7
@tallence-dsulyok
storybook: add profile menu as separate story - enable argsTable
0bac80b
@tallence-dsulyok
storybook: add profile menu as separate story - replaced dummy component
c9edc60
@tallence-dsulyok
storybook: add profile menu as separate story - style preview
beb68d6
@tallence-dsulyok
storybook: add profile menu as separate story - style preview
8f29a9d
@tallence-dsulyok
storybook: add profile menu as separate story - style preview
c828d8a
@tallence-dsulyok
storybook: add profile menu as separate story - hide args table
1dde0d9
@tallence-dsulyok
storybook: add profile menu as separate story - added component prope…
e1493a3 
…rties
@tallence-dsulyok
storybook: add profile menu as separate story - separate logged in / …
7f79bd7 
…logged out stories
@tallence-dsulyok tallence-dsulyok marked this pull request as ready for review December 12, 2023 13:37
@tallence-dsulyok
yarn lint & format
b2aafc6
@tallence-dsulyok
fix: code format
c8324ec
@tallence-dsulyok
docs: updated profile-menu dependencies
bfc49f8
@tallence-dsulyok
fix: menu status condition
8cf3953
@tallence-dsulyok
refactor: renamed component
cb3a25f
@tallence-dsulyok
refactor: renamed properties
d964f57
@tallence-dsulyok
refactor: renamed component folder
343a616
@tallence-dsulyok
fix: display in storybook
34330ea
@tallence-dsulyok
fix(storybook): state changeable in canvas tab
d5531bb
@tallence-dsulyok
fix(storybook): logout label in canvas tab after state change
efb267c
@tallence-dsulyok
fix: enable shadow dom
6e51c7f
@tallence-dsulyok
refactor: revert change of focus handling wehn closing menu-flyout
091b225
@tallence-dsulyok
fix: checkmark size in loggedIn-badge
780f931
@tallence-dsulyok
fix: trigger interaction state (remain black when activated)
de59c0b
@tallence-dsulyok
fix: close menu with Escape
bf2e46a
@tallence-dsulyok
fix: checkmark size in loggedIn-badge (mobile-menu)
6fdf35e
@tallence-dsulyok
docs(storybook): added english properties, fixed service urls
ebfb3cd
@tallence-dsulyok
docs(storybook): seperated german & english properties, fixed urls fo…
40192f2 
…r logged-out view
@tallence-dsulyok
fix: remove menu role from profile menu parents (so JAWS < 2023 does …
cd7c31f 
…not ignore links in menu)
@tallence-dsulyok
fix: remove aria-haspopup from profile menu trigger
9d2047f 
(so screenreaders do not imply menu role & navigation with arrow keys)
@tallence-dsulyok
fix: changed demo's page lang to german (for correct screenreader out…
f9f6ef1 
…put)
@tallence-dsulyok
fix: remove HR elements from accessibility tree
86ba3da
@acstll acstll merged commit 41374f0 into telekom:main Feb 8, 2024
9 of 12 checks passed
acstll added a commit that referenced this pull request Feb 8, 2024
@acstll
Revert "feat(telekom-profile-menu): WIP (#2208)"
8a5e883 
This reverts commit 41374f0.

Only temporarily to fix a few issues in the Flyout Menu
acstll pushed a commit that referenced this pull request Feb 8, 2024
chore: temporarily revert "feat(telekom-profile-menu): WIP (#2208)" (#…
b953a37 
…2274)

This reverts commit 41374f0.
@acstll acstll mentioned this pull request Feb 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maomaoZH maomaoZH Awaiting requested review from maomaoZH maomaoZH is a code owner

@acstll acstll Awaiting requested review from acstll

@felix-ico felix-ico Awaiting requested review from felix-ico

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tallence-dsulyok @acstll