fix(tab-nav): content clickable for screen readers #1692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for marvelous-moxie-a6e2fe ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
nowseemee
reviewed
Mar 24, 2023
|
|
||
| @State() hasFocus: boolean = false; | ||
|
|
||
| @Event({ eventName: 'scale-select' }) scaleSelect: EventEmitter; |
There was a problem hiding this comment.
should we scope this event to avoid collisions?
There was a problem hiding this comment.
we could, but I think it makes sense to also have this event be "public", no?
nowseemee
reviewed
Mar 24, 2023
| handleSelect(event) { | ||
| const nextTab = event.target as HTMLScaleTabHeaderElement; | ||
| // Act only if it's a direct child | ||
| if (this.getAllEnabledTabs().includes(nextTab)) { |
There was a problem hiding this comment.
...or this takes care of collisions?
There was a problem hiding this comment.
this takes care of collisions with nested tabs… (an issue we had reported not long ago)
There was a problem hiding this comment.
actually with nested anything haha
nowseemee
approved these changes
Mar 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #957
I removed the
clickhandler fromtab-nav.tsxand made thescale-tab-headeremit ascale-selectevent.@nowseemee let me know what you think!