Fix/no label input dropdown #1619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for marvelous-moxie-a6e2fe ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
acstll
requested changes
Feb 24, 2023
There was a problem hiding this comment.
Removing the label is definitely a bad idea as you suggest, for accessibility reasons. But I think we can provide allowing to hide the label, as requested, if we follow the recommendations here https://www.w3.org/WAI/tutorials/forms/labels/#hiding-label-text
So we try and make sure there is always a label, either visible or not.
I can think of two options, but probably there are many more:
- We make the
labelrequired, and add ahideLabelVisuallyprop to make it visually hidden, and adjust the layout for the input text to be vertically aligned as in this PR ("approach 1" in the article) - We add an
innerAriaLabelprop, and adjust the layout when no label is present ("approach 2" in the article)
@felix-ico what do you think?
|
@acstll I'd go for approach # 1, I'll make the necessary changes! 🙌 |
Co-authored-by: felix-ico <[email protected]>
acstll
requested changes
Mar 17, 2023
| @@ -241,16 +242,15 @@ export class TextField { | |||
| 'datetime-local', | |||
| ]; | |||
|
|
|||
| console.log('HIDE LABEL ? ', this.hideLabelVisually, this.label); | |||
There was a problem hiding this comment.
?? I'm not sure what happened here but this was removed a while ago 129a2b6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this would fix #827 ...not sure if it's a good idea to allow inputs without labels though