Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(telekom-header): flyout hover/click handling #1505

Merged
merged 3 commits into from
Jan 23, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,13 @@
| `triggerSelector` | `trigger-selector` | Selector to query the trigger element in case it's not the previous sibling | `string` | `undefined` |


## Events

| Event | Description | Type |
| ---------------- | ----------- | ------------------ |
| `scale-expanded` | | `CustomEvent<any>` |


## Methods

### `hide() => Promise<void>`
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ import {
h,
Host,
Element,
Event,
Listen,
Method,
Prop,
Expand All @@ -22,6 +23,7 @@ import {
} from '@stencil/core';
import { HTMLStencilElement } from '@stencil/core/internal';
import cx from 'classnames';
import { emitEvent } from '../../../utils/utils';

// TODO make util
const animFinished = (el: HTMLElement | ShadowRoot) => {
Expand Down Expand Up @@ -58,6 +60,8 @@ export class TelekomNavItem {
@State() isExpanded: boolean = this.expanded;
@State() animationState: 'in' | 'out' | undefined;

@Event({ eventName: 'scale-expanded', bubbles: true }) scaleExpanded;

private parentElement: HTMLElement;

@Listen('keydown', { target: 'window' })
Expand All @@ -73,16 +77,6 @@ export class TelekomNavItem {
}
}

// @Listen('focusin', { target: 'document' })
// handleDocumentFocusin(event) {
// if (!this.isExpanded) {
// return;
// }
// if (!this.hostElement.contains(event.target)) {
// this.expanded = false;
// }
// }

@Listen('scale-close-nav-flyout')
handleScaleCloseNavFlyout() {
this.expanded = false;
Expand Down Expand Up @@ -114,24 +108,43 @@ export class TelekomNavItem {
}
this.triggerElement.setAttribute('aria-haspopup', 'true');
this.triggerElement.setAttribute('aria-expanded', String(this.expanded));
this.triggerElement.addEventListener('click', this.handleTriggerClick);
if (this.hover) {
this.triggerElement.addEventListener('mouseenter', this.handlePointerIn);
this.triggerElement.addEventListener(
'keypress',
this.handleSpaceOrEnterForHover
);
} else {
this.triggerElement.addEventListener('click', this.handleTriggerClick);
}
}

disconnectedCallback() {
this.triggerElement.removeEventListener('click', this.handleTriggerClick);
this.triggerElement.removeEventListener('mouseenter', this.handlePointerIn);
this.triggerElement.removeEventListener(
'keypress',
this.handleSpaceOrEnterForHover
);
}

handleSpaceOrEnterForHover = (event: KeyboardEvent) => {
if (this.isExpanded) {
return;
}
if (event.key === 'Enter' || event.key === ' ') {
this.expanded = true;
this.show();
}
};

handleTriggerClick = (event: MouseEvent) => {
if (event.ctrlKey) {
return;
}
event.preventDefault();
event.stopImmediatePropagation();
this.expanded = !this.expanded;
this.expanded ? this.show() : this.hide();
this.parentElement.removeEventListener('mouseleave', this.handlePointerOut);
};

Expand All @@ -156,6 +169,7 @@ export class TelekomNavItem {
await animFinished(this.hostElement.shadowRoot);
this.animationState = undefined;
this.triggerElement.setAttribute('aria-expanded', 'true');
emitEvent(this, 'scaleExpanded', { expanded: true });
});
}

Expand All @@ -167,6 +181,7 @@ export class TelekomNavItem {
this.animationState = undefined;
this.isExpanded = false;
this.triggerElement.setAttribute('aria-expanded', 'false');
emitEvent(this, 'scaleExpanded', { expanded: false });
});
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,8 @@
cursor: pointer;
}

.scale-telekom-nav-item > :where(a, button):hover {
.scale-telekom-nav-item > :where(a, button):hover,
.scale-telekom-nav-item > :where(button[aria-expanded='true']) {
color: var(--telekom-color-text-and-icon-primary-hovered);
}
.scale-telekom-nav-item > :where(a, button):active {
Expand Down Expand Up @@ -116,6 +117,28 @@
left: 0;
}

.scale-telekom-nav-list[variant='main-nav']
> .scale-telekom-nav-item
> :where(a, button):hover:after,
.scale-telekom-nav-list[variant='main-nav']
> .scale-telekom-nav-item
> :where(button[aria-expanded='true']):after,
.scale-telekom-nav-list[variant='functions']
> .scale-telekom-nav-item
> :where(a, button):hover:after,
.scale-telekom-nav-list[variant='functions']
> .scale-telekom-nav-item
> :where(button[aria-expanded='true']):after {
content: '';
width: 100%;
height: var(--telekom-spacing-unit-x05);
background: var(--telekom-color-primary-standard);
display: block;
position: absolute;
bottom: 0;
left: 0;
}

/* variants: meta-nav-external, meta-nav, lang-switcher (top bar) */

.scale-telekom-nav-list[variant='meta-nav-external']
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,12 @@
* file, You can obtain one at https://mozilla.org/MPL/2.0/.
*/

import { Component, h, Host, Element, Prop } from '@stencil/core';
import { Component, h, Host, Element, Listen, Prop } from '@stencil/core';
import { HTMLStencilElement } from '@stencil/core/internal';

const isDirectChild = (parent: HTMLElement, child: HTMLElement) =>
[...parent.children].includes(child);

@Component({
tag: 'scale-telekom-nav-list',
styleUrl: 'telekom-nav-list.css',
Expand All @@ -28,6 +31,25 @@ export class TelekomNavList {
| 'main-nav'
| 'functions' = 'main-nav';

@Listen('scale-expanded')
handleScaleExpanded(event) {
if (event.detail.expanded) {
this.closeExpandedFlyoutSiblings(event.target);
}
}

closeExpandedFlyoutSiblings(target: HTMLElement) {
const siblingItems = [...this.hostElement.children].filter(
(x) => !x.contains(target)
) as HTMLElement[];
siblingItems.forEach((item) => {
const flyout = item.querySelector('scale-telekom-nav-flyout');
if (isDirectChild(item, flyout) && flyout.expanded) {
flyout.expanded = false;
}
});
}

render() {
return (
<Host class="scale-telekom-nav-list">
Expand Down