-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add segmented-button #1429
Merged
felix-ico
merged 3 commits into
preview-chips-segmentedbutton
from
feat/segmented-button
Jan 25, 2023
Merged
feat: add segmented-button #1429
felix-ico
merged 3 commits into
preview-chips-segmentedbutton
from
feat/segmented-button
Jan 25, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your Render PR Server URL is https://telekom-scale-storybook-preview-pr-1429.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-cee864p4reb7d00tr4m0. |
This was referenced Jan 9, 2023
felix-ico
force-pushed
the
feat/segmented-button
branch
from
January 18, 2023 14:22
81c040d
to
cc826e3
Compare
nowseemee
added a commit
that referenced
this pull request
Jan 25, 2023
* feat(chip): init component * refactor: cleaning up component * feat: init new chip concept * feat: adding dismissible and selected functionality's * feat: adding possibility for icons * feat: adding unit test and storybook init * feat: adding accessibility, disabled and removing magic numbers * refactor: solving linting errors * fix: naming * fix: reference error * fix: reference error * fix: reference error * refactor: changing story naming * feat: init visual tests * refactor: deleting href test case * refactor: changing close trigger * refactor: changing focus outline style * refactor: updating visual snapshots * refactor: deleting unneeded props * feat: adding focus and active state * feat: adding storybook stories * fix: not loading project * feat: adding focus state * feat: implement new design * refactor: storybook stories * feat: add segmented-button * refactor: changing stories chip label and deleting icon size property * refactor: changing stories label * fix: removing unneeded icon size property * refactor: updating visual snapshots * test(visual): update snapshots (#1434) Co-authored-by: marvinLaubenstein <[email protected]> * fix: solving color problem and transition bug * refactor: changing label prop to slot * test(visual): update snapshots (#1436) Co-authored-by: marvinLaubenstein <[email protected]> * refactor: changing icon to selected * fix: add refactoring from separate branch * test(visual): update snapshots (#1456) Co-authored-by: felix-ico <[email protected]> * refactor: renaming segmented-button to segment and segmented-button-g… (#1458) * refactor: renaming segmented-button to segment and segmented-button-group to segmented-button * refactor: updating visual snapshots * refactor: deleting snapshots for better merging * test(visual): update snapshots (#1457) Co-authored-by: felix-ico <[email protected]> * test(visual): update snapshots (#1459) Co-authored-by: felix-ico <[email protected]> * test(visual): update snapshots (#1461) Co-authored-by: felix-ico <[email protected]> * test(visual): update snapshots (#1462) Co-authored-by: felix-ico <[email protected]> * feat: disable deselecting on single-select * fix: lint * fix: format * fix: improve naming * test: update snapshot * refactor: introducing new dynamic and persistent structure * refactor: changing disabled functionality * refactor: updating storybook stories * fix: solving loading issues * refactor: updating visual snapshots * feat: adding example story for dynamic * refactor: changing selected icon state setting * refactor: improving storybook page * refactor: updating visual snapshots * fix: merging problem * fix: solving storybook preview problem * fix: quickfix * refactor: removing example story * refactor: changing minor styling in storybook * feat: add fullwidth prop * fix: remove ts-ignore * feat: add fullwidth prop to story * fix: format * fix: missing closing bracket * fix: style * fix: format * test(visual): update snapshots (#1496) Co-authored-by: felix-ico <[email protected]> * Feat/chip and segmented button usage text (#1501) * feat: adding usage text for chip * feat: adding usage text for segmented button * feat: adding history text * refactor: updating segmented button snapshots * refactor: changing design matters * fix: solving design notes * refactor: deleting slitted view / mobile view issues * refactor: including design feedback * Refactor/chips segmentedbutton (#1512) * refactor: changing unselected horizontal padding * refactor: updating visual snapshots * feat: add segmented-button (#1429) * fix: ts, a11y, story * test(visual): update snapshots (#1497) Co-authored-by: felix-ico <[email protected]> * test(visual): update snapshots (#1513) Co-authored-by: marvinLaubenstein <[email protected]> * test(visual): update snapshots (#1514) Co-authored-by: felix-ico <[email protected]> * fix: solving visual testing fails * fix: remove unneeded dep, remove unneeded file * fix: remove wrong deprecation warning * test: disable segmented button vis test * test(segmented-button): disable * test(visual): update snapshots (#1516) Co-authored-by: nowseemee <[email protected]> Co-authored-by: Marvin_Laubenstein <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: marvinLaubenstein <[email protected]> Co-authored-by: felix-ico <[email protected]> Co-authored-by: Daniel Beck <[email protected]> Co-authored-by: nowseemee <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.