Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(data-grid): enable content width check for actions cell #1108

Merged
merged 1 commit into from
Jun 23, 2022
Merged

fix(data-grid): enable content width check for actions cell #1108

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions packages/components/src/components/data-grid/cell-handlers/actions-cell.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,6 @@ import { Cell } from './cell-interface';

export const ActionsCell: Cell = {
defaults: {},
getLongestContent({ rows, columnIndex }) {
// Skip check as content width is always the same
return rows[0][columnIndex];
},
render: ({ content }) => {
return (
<div class={`tbody__actions`}>
Expand Down
5 changes: 5 additions & 0 deletions packages/components/src/html/data-grid.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -302,6 +302,11 @@
variant: 'secondary',
onClick: () => alert('Delete'),
},
{
label: 'Third action',
variant: 'secondary',
onClick: () => alert('Third action'),
},
],
],

Expand Down