Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add min max attribute to text-field #988

Merged
merged 5 commits into from
Apr 13, 2022
Merged

feat: add min max attribute to text-field #988

merged 5 commits into from
Apr 13, 2022

Conversation

maomaoZH
Copy link
Collaborator

No description provided.

@maomaoZH maomaoZH requested a review from acstll April 11, 2022 09:14
@maomaoZH maomaoZH requested a review from nowseemee as a code owner April 11, 2022 09:14
@render
Copy link

render bot commented Apr 11, 2022

Your Render PR Server URL is https://scale-storybook-staging-pr-988.onrender.com.

Follow its progress at https://dashboard.render.com/web/srv-c99v2s7ho1ki56mgmel0.

@maomaoZH maomaoZH linked an issue Apr 11, 2022 that may be closed by this pull request
scale-text-field min/max property at type number #971
Closed
acstll
acstll reviewed Apr 11, 2022
View reviewed changes
Copy link
Collaborator

@acstll acstll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! thank you @maomaoZH

I only left a question regarding the label…

packages/components/src/components/text-field/text-field.tsx Outdated Show resolved Hide resolved
@maomaoZH maomaoZH force-pushed the feat/add-min-max-props-to-textfield branch from 1786744 to abd1a1f Compare April 11, 2022 09:28
@maomaoZH maomaoZH force-pushed the feat/add-min-max-props-to-textfield branch from 3888e8b to 5e064c5 Compare April 11, 2022 10:04
@acstll acstll merged commit a073dfb into main Apr 13, 2022
@acstll acstll deleted the feat/add-min-max-props-to-textfield branch April 13, 2022 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acstll acstll acstll left review comments

@nowseemee nowseemee Awaiting requested review from nowseemee

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

scale-text-field min/max property at type number
2 participants
@maomaoZH @acstll