Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scale-text-field min/max property at type number #971

Closed
peterszeles opened this issue Apr 4, 2022 · 2 comments · Fixed by #988
Closed

scale-text-field min/max property at type number #971

peterszeles opened this issue Apr 4, 2022 · 2 comments · Fixed by #988
Labels
feature New component features and enhancements

Comments

@peterszeles
Copy link

peterszeles commented Apr 4, 2022

Hi there,

I found out that the <scale-text-field></scale-text-field> component does not support min and max property at type=number. There is only max-length and min-length props which are only for text input. Is it planned for the future to add min and max props to this component? Or is it planned to create a new component for numbers like <scale-input-field>?
I need something like this: <scale-text-field type="number" min="1" max="10" step="1"></scale-text-field>

Thank you :)

@peterszeles peterszeles changed the title scale-text-field min/max value at type number scale-text-field min/max property at type number Apr 4, 2022
@acstll acstll added the feature New component features and enhancements label Apr 4, 2022
@acstll
Copy link
Collaborator

acstll commented Apr 4, 2022

Thanks @peterszeles for opening this.

We can add the min and max attributes to scale-text, those are certainly missing 👍

@peterszeles
Copy link
Author

Cool, thank you so much :)

@maomaoZH maomaoZH linked a pull request Apr 11, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New component features and enhancements
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants