Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: typo #2248

Merged
merged 5 commits into from
Jan 10, 2024
Merged

fix: typo #2248

merged 5 commits into from
Jan 10, 2024

Conversation

felix-ico
Copy link
Collaborator

@netlify Netlify
Copy link

netlify bot commented Jan 5, 2024 •
edited
Loading

✅ Deploy Preview for marvelous-moxie-a6e2fe ready!

Name Link
🔨 Latest commit f3804a7
🔍 Latest deploy log https://app.netlify.com/sites/marvelous-moxie-a6e2fe/deploys/659ebc370430030008bf104d
😎 Deploy Preview https://deploy-preview-2248--marvelous-moxie-a6e2fe.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ledex
Copy link

ledex commented Jan 9, 2024

Hi all! No hurry, but is there an ETA for this fix? @maomaoZH @acstll

@felix-ico
Copy link
Collaborator Author

Hey @ledex apparently this change fixes the issue in react, but reintroduces it in vanilla apps - i am having another look

@ledex
Copy link

ledex commented Jan 9, 2024

Sounds interesting 🤔 Okay but as I said no rush... I was just wondering.

acstll
acstll approved these changes Jan 10, 2024
View reviewed changes
Copy link
Collaborator

@acstll acstll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@felix-ico felix-ico closed this Jan 10, 2024
@felix-ico felix-ico reopened this Jan 10, 2024
@github-actions github-actions bot mentioned this pull request Jan 10, 2024
Closed
@felix-ico felix-ico merged commit bab9369 into main Jan 10, 2024
18 of 19 checks passed
@felix-ico felix-ico deleted the fix/enable-programmatically branch January 10, 2024 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acstll acstll acstll approved these changes

@maomaoZH maomaoZH Awaiting requested review from maomaoZH maomaoZH is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@felix-ico @ledex @acstll