Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tab Navigation]: Programatically enabling tab does not work #2239

Closed
ledex opened this issue Dec 12, 2023 · 6 comments
Closed

[Tab Navigation]: Programatically enabling tab does not work #2239

ledex opened this issue Dec 12, 2023 · 6 comments
Assignees
Labels
bug Something isn't working

Comments

@ledex
Copy link

ledex commented Dec 12, 2023

Scale Version
3.0.0-beta.142

Framework and version
React 17.0.2

Current Behavior
When enabling a tab in the tab navigation programatically (as seen below), the tab button in the navigation becomes enabled again, but navigation to the tab panel does not work.

<ScaleTabHeader slot={"tab"} disabled={!eventData?.metadata}>
     <ScaleIconAlertInformation/> Metadata
</ScaleTabHeader>

Expected Behavior
When enabling a tab in the gab navigation programatically it should become available to the user and the user should be able to navigate there.

Code Reproduction
https://codesandbox.io/p/sandbox/scale-components-react18-forked-ccr4g4

Desktop (please complete the following information):

  • OS: Windows
  • Browser: Firefox/Chromium
@ledex ledex added the bug Something isn't working label Dec 12, 2023
@felix-ico felix-ico self-assigned this Dec 18, 2023
@felix-ico
Copy link
Collaborator

hi @ledex, this issue should be fixed on the latest release 3.0.0-beta.146

please feel free to reopen if that's not the case

@ledex
Copy link
Author

ledex commented Jan 5, 2024

Hi @felix-ico! I cannot reopen this issue, but it seems that this bug is not fixed yet. I've updated my codesandbox to beta.146 and it still does not work. I can also still reproduce this issue in our code...

@felix-ico felix-ico reopened this Jan 5, 2024
@felix-ico felix-ico mentioned this issue Jan 5, 2024
@felix-ico
Copy link
Collaborator

weirdly my initial fix was working in a vanilla js app but not in the react context, this new PR seems to fix the issue completely

@ledex
Copy link
Author

ledex commented Jan 5, 2024

No worries, I'll try it out once the new version has been released :)

@felix-ico
Copy link
Collaborator

this issue should be fixed in 3.0.0-beta.147

@ledex
Copy link
Author

ledex commented Jan 18, 2024

Works for me now. Thanks for the fast fix :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants