-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Tab Navigation]: Programatically enabling tab does not work #2239
Comments
hi @ledex, this issue should be fixed on the latest release 3.0.0-beta.146 please feel free to reopen if that's not the case |
Hi @felix-ico! I cannot reopen this issue, but it seems that this bug is not fixed yet. I've updated my codesandbox to beta.146 and it still does not work. I can also still reproduce this issue in our code... |
weirdly my initial fix was working in a vanilla js app but not in the react context, this new PR seems to fix the issue completely |
No worries, I'll try it out once the new version has been released :) |
this issue should be fixed in 3.0.0-beta.147 |
Works for me now. Thanks for the fast fix :) |
Scale Version
3.0.0-beta.142
Framework and version
React 17.0.2
Current Behavior
When enabling a tab in the tab navigation programatically (as seen below), the tab button in the navigation becomes enabled again, but navigation to the tab panel does not work.
Expected Behavior
When enabling a tab in the gab navigation programatically it should become available to the user and the user should be able to navigate there.
Code Reproduction
https://codesandbox.io/p/sandbox/scale-components-react18-forked-ccr4g4
Desktop (please complete the following information):
The text was updated successfully, but these errors were encountered: