fix: disabled indeterminate state master handling

telekom · Jul 19, 2021 · c496b86 · c496b86
1 parent b6e2804
commit c496b86
Show file tree

Hide file tree

Showing 2 changed files with 28 additions and 27 deletions.
diff --git a/packages/components-sketch/views/checkbox-group.hbs b/packages/components-sketch/views/checkbox-group.hbs
@@ -5,33 +5,33 @@
     <div class="agent-states--grid">
         <div class="agent-states--item">
             <p class="agent-states--label">:available</p>
-    <scale-checkbox-group data-sketch-key="checkbox-group-1" label="Checkbox Group Label">
-      <div slot="checkbox-header">
-        <scale-checkbox
-          input-id="header-checkbox"
-          value="1"
-          label="checkbox"
-          name="nameOfCheckbox"
-          helper-text="helperText"
-        >
-        </scale-checkbox>
-      </div>
-      <div slot="checkbox-list">
-        <div style="margin-top: 0.5rem">
-          <scale-checkbox
-            value="2"
-            label="checkbox"
-            name="nameOfCheckbox"
-          ></scale-checkbox>
-        </div>
-        <div style="margin-top: 0.5rem">
-          <scale-checkbox value="3" name="nameOfCheckbox" 
-            >Checkbox Slot</scale-checkbox
-          >
-        </div>
-      </div>
-    </scale-checkbox-group data-sketch-key="checkbox-group-2" label="Checkbox Group Label">
-        </div>
+            <scale-checkbox-group data-sketch-key="checkbox-group-1" label="Checkbox Group Label">
+            <div slot="checkbox-header">
+                <scale-checkbox
+                    input-id="header-checkbox"
+                    value="1"
+                    label="checkbox"
+                    name="nameOfCheckbox"
+                    helper-text="helperText"
+                >
+                </scale-checkbox>
+            </div>
+            <div slot="checkbox-list">
+             <div style="margin-top: 0.5rem">
+                <scale-checkbox
+                    value="2"
+                    label="checkbox"
+                    name="nameOfCheckbox"
+                ></scale-checkbox>
+            </div>
+            <div style="margin-top: 0.5rem">
+                <scale-checkbox value="3" name="nameOfCheckbox" >
+                    Checkbox Slot
+                </scale-checkbox>
+            </div>
+        </div>
+        </scale-checkbox-group data-sketch-key="checkbox-group-2" label="Checkbox Group Label">
+    </div>
         <div class="agent-states--item">
             <p class="agent-states--label">:hover</p>
               <scale-checkbox-group>

diff --git a/packages/components/src/components/checkbox-group/checkbox-group.tsx b/packages/components/src/components/checkbox-group/checkbox-group.tsx
@@ -61,6 +61,7 @@ export class CheckboxGroup {
         }
       }
     } else {
+      this.setMasterCheckBoxState(newState);
       this.handleMasterDisableProp();
     }
   }
-Original file line number
+Diff line change
@@ Expand Up / @@ -61,6 +61,7 @@ export class CheckboxGroup { @@
             }
           }
         } else {
+          this.setMasterCheckBoxState(newState);
           this.handleMasterDisableProp();
         }
       }
@@ Expand Down @@