Skip to content

Commit

Permalink
fix: accordion spacing and icon size (#1936)
Browse files Browse the repository at this point in the history
  • Loading branch information
felix-ico authored Jun 5, 2023
1 parent 9c6fbce commit bf3e60d
Show file tree
Hide file tree
Showing 28 changed files with 5 additions and 12 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ exports[`TextField should match snapshot 1`] = `
<div class="collapsible" part="base">
<h2 aria-level="2" class="collapsible__heading" part="heading">
<button aria-controls="collapsable-panel-0" aria-expanded="false" class="collapsible__button" id="collapsable-heading-0" part="button">
<scale-icon-navigation-right class="collapsible__icon" decorative="" part="icon" size="20"></scale-icon-navigation-right>
<scale-icon-navigation-right class="collapsible__icon" decorative="" part="icon" size="24"></scale-icon-navigation-right>
<span class="collapsible__button-text" part="button-text">
<slot name="heading"></slot>
</span>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,12 +26,9 @@
--focus-outline: var(--telekom-line-weight-highlight) solid
var(--telekom-color-functional-focus-standard);

/* icon */
--spacing-top-icon: var(--telekom-spacing-unit-x1);

/* content */
--spacing-right-content: var(--telekom-spacing-unit-x12);
--spacing-left-content: var(--telekom-spacing-unit-x8);
--spacing-left-content: 34px;
--spacing-top-content: var(--telekom-spacing-unit-x4);
--spacing-bottom-content: var(--telekom-spacing-unit-x6);
}
Expand Down Expand Up @@ -63,7 +60,7 @@
width: 100%;
display: flex;
text-align: left;
align-items: flex-start;
align-items: center;
padding-top: 0;
border-color: transparent;
border-style: solid;
Expand Down Expand Up @@ -104,7 +101,6 @@

.collapsible__icon {
flex-shrink: 0;
margin-top: var(--spacing-top-icon);
}

.collapsible__icon-right {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ export interface CollapsibleEventDetail {
expanded: boolean;
}

const DEFAULT_ICON_SIZE = 20;
const DEFAULT_ICON_SIZE = 24;

let i = 0;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -122,12 +122,9 @@ export const Template = (args, { argTypes }) => ({
--background-button-hover: var(--telekom-color-ui-state-fill-hovered);
--border-color-button-focus: var(--telekom-color-functional-focus);

/* icon */
--spacing-top-icon: calc(var(--telekom-spacing-unit-x1) + 1px);

/* content */
--spacing-right-content: var(--telekom-spacing-unit-x12);
--spacing-left-content: var(--telekom-spacing-unit-x8);
--spacing-left-content: 34px;
--spacing-top-content: var(--telekom-spacing-unit-x4);
--spacing-bottom-content: var(--telekom-spacing-unit-x6);
}
Expand Down
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.

0 comments on commit bf3e60d

Please sign in to comment.