Skip to content

Commit

Permalink
fix(dropdown): hardcoded bg color in dark mode (temp) (#1059)
Browse files Browse the repository at this point in the history
* fix: temporary fix - hardcoded dark mode bg color in dropdwon

* test: update visual tests

* fix: simulate hover opacity, update tests

* fix: format
  • Loading branch information
felix-ico authored May 18, 2022
1 parent 3278442 commit 3818ed8
Show file tree
Hide file tree
Showing 8 changed files with 23 additions and 0 deletions.
23 changes: 23 additions & 0 deletions packages/components/src/components/dropdown/dropdown.css
Original file line number Diff line number Diff line change
Expand Up @@ -135,6 +135,7 @@ scale-dropdown {
border-color: var(--border-color-hover);
background-color: var(--telekom-color-ui-outlined-fill-hovered);
}

.dropdown:not(.dropdown--disabled).dropdown--status-error
.input__dropdown:hover {
border-color: var(--telekom-color-functional-danger-hovered);
Expand Down Expand Up @@ -226,3 +227,25 @@ scale-dropdown {
color: var(--color-disabled);
background: var(--background-disabled);
}

/* Tokens exceptionally hard-coded, instead of using the component variables,
to fix bug in Firefox/Windows, see https://github.com/telekom/scale/issues/1018) */
[data-mode='dark'] .dropdown .input__dropdown {
background-color: var(--telekom-color-background-canvas);
}

[data-mode='dark']
.dropdown:not(.dropdown--disabled):not(.dropdown--status-error)
.input__dropdown:hover {
background-color: #1b1b1b;
}

[data-mode='dark']
.dropdown:not(.dropdown--disabled).dropdown--status-error
.input__dropdown:hover {
background-color: #1b1b1b;
}

[data-mode='dark'] .dropdown--disabled .input__dropdown {
background-color: var(--telekom-color-background-canvas);
}
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.

0 comments on commit 3818ed8

Please sign in to comment.