Skip to content

Commit

Permalink
fix: use _semantic_ CSS variables for consistency (#742)
Browse files Browse the repository at this point in the history
  • Loading branch information
christopherGdynia authored Dec 17, 2021
1 parent 090b1ab commit 15af88b
Show file tree
Hide file tree
Showing 6 changed files with 8 additions and 7 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
white-space: nowrap;
border-radius: 0;
cursor: pointer;
color: var(--scl-color-black);
color: var(--scl-color-text-standard);
/* 10px relates to the PAD value in Menu component */
max-width: calc(100vw - 2 * var(--scl-spacing-24) - 2 * 10px);
overflow: hidden;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
position: absolute;
pointer-events: initial;
z-index: var(--scl-z-index-20);
background: var(--scl-color-white);
background: var(--scl-color-background-standard);
border-radius: var(--scl-radius-12);
box-shadow: var(--scl-shadow-level-4);
overflow-y: hidden;
Expand Down
3 changes: 2 additions & 1 deletion packages/components/src/components/modal/modal.css
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@
position: relative;
overflow-y: auto;
flex-direction: column;
background-color: white;
background-color: var(--scl-color-background-standard);
max-height: var(--max-height-window);
border-radius: var(--radius-window);
box-shadow: var(--box-shadow-window);
Expand Down Expand Up @@ -185,6 +185,7 @@
appearance: none;
cursor: pointer;
user-select: none;
color: var(--scl-color-text-standard);
}

.modal__close-button:focus {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ scale-app-header {
--background-brand: var(--scl-color-primary);

--color-nav: var(--scl-color-text-standard);
--background-nav: var(--scl-color-white);
--background-nav: var(--scl-color-background-standard);
--spacing-nav: 0 var(--scl-spacing-16);
}
@keyframes keyframes-slideUp {
Expand Down Expand Up @@ -112,7 +112,7 @@ scale-app-header {
height: calc(2 * var(--header-border-radius));
position: absolute;
border-top: var(--border);
box-shadow: 0 calc(-1 * var(--header-border-radius)) 0 0 #fff;
box-shadow: 0 calc(-1 * var(--header-border-radius)) 0 0 var(--scl-color-background-standard);
background-color: transparent;
}
.header.menu--open .header__nav-before,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ app-mega-menu {
--spacing-y: 34px;
--spacing-right: var(--scl-spacing-16);
--spacing-left: var(--scl-spacing-24);
--background: var(--scl-color-white);
--background: var(--scl-color-background-standard);
--color-active: var(--scl-color-primary);

--font-size-row-title: var(--scl-font-size-16);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ app-navigation-main-mobile {
position: absolute;
top: 0;
left: 0;
background: var(--scl-color-white);
background: var(--scl-color-background-standard);
width: 100%;
min-height: var(--min-height);
}
Expand Down

0 comments on commit 15af88b

Please sign in to comment.