Skip to content

Commit

Permalink
feat(footer): dynamic copyright text (#318)
Browse files Browse the repository at this point in the history
* feat(footer): dynamic copyright text

* test(footer): update snapshots

* test(footer): update visual snapshots
  • Loading branch information
nowseemee authored May 3, 2021
1 parent ecdfd2a commit 04d1ad3
Show file tree
Hide file tree
Showing 8 changed files with 15 additions and 10 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ exports[`AppFooter should match snapshot 1`] = `
<app-logo claim=""></app-logo>
</div>
<div class="footer-copyright">
© Deutsche Telekom GmbH
© Deutsche Telekom AG
</div>
<nav aria-label="bottom" class="footer-navigation">
<ul></ul>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ export class AppFooter {
@Prop() claimLang: string;
@Prop() footerNavigation?: any = [];
@Prop() variant?: string = 'standard';
@Prop() copyright?: string = '© Deutsche Telekom AG';
/** (optional) Injected CSS styles */
@Prop() styles?: string;

Expand Down Expand Up @@ -89,7 +90,7 @@ export class AppFooter {
<div class="footer-branding">
<app-logo claim claimLang={this.claimLang}></app-logo>
</div>
<div class="footer-copyright">© Deutsche Telekom GmbH</div>
<div class="footer-copyright">{this.copyright}</div>
<nav aria-label="bottom" class="footer-navigation">
{this.footerMenu()}
</nav>
Expand Down
13 changes: 7 additions & 6 deletions packages/components/src/components/telekom/app-footer/readme.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,13 @@

## Properties

| Property | Attribute | Description | Type | Default |
| ------------------ | ------------------- | ------------------------------ | -------- | ------------ |
| `claimLang` | `claim-lang` | | `string` | `undefined` |
| `footerNavigation` | `footer-navigation` | | `any` | `[]` |
| `styles` | `styles` | (optional) Injected CSS styles | `string` | `undefined` |
| `variant` | `variant` | | `string` | `'standard'` |
| Property | Attribute | Description | Type | Default |
| ------------------ | ------------------- | ------------------------------ | -------- | ------------------------- |
| `claimLang` | `claim-lang` | | `string` | `undefined` |
| `copyright` | `copyright` | | `string` | `'© Deutsche Telekom AG'` |
| `footerNavigation` | `footer-navigation` | | `any` | `[]` |
| `styles` | `styles` | (optional) Injected CSS styles | `string` | `undefined` |
| `variant` | `variant` | | `string` | `'standard'` |


## Dependencies
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
:claim-lang="claimLang"
:footer-navigation="footerNavigation"
:variant="variant"
:copyright="copyright"
></scale-app-footer>
</template>

Expand All @@ -11,7 +12,8 @@ export default {
props: {
claimLang: String,
footerNavigation: String,
variant: String
variant: String,
copyright: String,
}
};
</script>
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ export const Template = (args, { argTypes }) => ({
:claim-lang="claimLang"
:footer-navigation="footerNavigation"
:variant="variant"
:copyright="copyright"
>
</scale-app-footer>
</div>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ The footer finishes off all Telekom websites. Users can find important informati

## General

Scale offers different variations of the footer. Links to the imprint and data protection information, as well as the acknowledgement of Deutsche Telekom as the content provider, are required for all variations.
Scale offers different variations of the footer. Links to the legal notice and data protection information, as well as the acknowledgement of Deutsche Telekom as the content provider, are required for all variations.

## Basic Types

Expand Down
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.

0 comments on commit 04d1ad3

Please sign in to comment.