Windows build doc: add Graphviz to third party install list #28334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
That's a wrong fix, graphviz shouldn't be needed. |
|
Probably, but after install and rerun win.bat error message gone. |
|
It's still a wrong fix. It should build without graphviz installed. |
|
There is also the same issue: Error running win.bat #27899, it was resolved by Graphviz install. I agree that root cause could be something else. |
|
The right fix for #27899 is to remove doxygen so libheif doesn't look for graphviz |
|
Doxygen seems to be OFF in all occurrences https://github.com/search?q=repo%3Atelegramdesktop%2Ftdesktop%20doxygen&type=code |
I'm not sure what you want to say by that. The issue you linked says |
Sopheap-cloud
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an error message
problems opening map file libheif/apidoc/html/heif_8h__incl.mapwhile runningwin.batwithout Graphviz installed.Add it to third party software list.