Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users to filter message searches by channel sender in groups #25104

Open
wants to merge 6 commits into
base: dev
Choose a base branch
from

Conversation

TheWug
Copy link

@TheWug TheWug commented Sep 21, 2022

Users can send messages as channels in any supergroup which either has a public username or is linked to a channel. Previously it was not possible to filter by sender for messages sent on behalf of a channel, and now it is. In order to avoid confusion, you must search by the channel's exact username, and the group must permit sending messages as channels.

It is worth considering whether chat administrators should always be able to search for messages by any channel, regardless of group or channel settings, to ensure they can handle adversarial situations, but this pull request addresses only the simple case.

closes #25105

Users can send messages as channels in any supergroup which either
has a public username or is linked to a channel. Previously it was
not possible to filter by sender for messages sent on behalf of a
channel, and now it is. In order to avoid confusion, you must search
by the channel's exact username, and the group must permit sending
messages as channels.

It is worth considering whether chat administrators should always be
able to search for messages by any channel, regardless of group or
channel settings, to ensure they can handle adversarial situations.
@CLAassistant
Copy link

CLAassistant commented Sep 21, 2022

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ TheWug
❌ Wug


Wug seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

It is impossible to search for messages posted in chats by masqueraded channels
3 participants