Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Hide photo viewer overlay after zooming an image #7931

Open
aleksusklim opened this issue May 22, 2020 · 6 comments · May be fixed by #16303
Open

Enhancement: Hide photo viewer overlay after zooming an image #7931

aleksusklim opened this issue May 22, 2020 · 6 comments · May be fixed by #16303

Comments

@aleksusklim
Copy link

Is your feature request related to a problem?

Often photos have a long textual description, or sent as album. In this case, after clicking on it, the internal image viewer will show both description (shortened) and two of other photos from this album.

This interactive information will stay on screen until some timeout (about 3 sec) and then slowly fade. But only if no user mouse input was detected! So, for example, if you want to pan zoomed-in image, you will trigger displaying of this interface, which might overlap some important parts of the picture.

Waiting for it to disappear every time is not convenient.

Describe the solution you'd like

Disable any onscreen controls in image viewer if this picture was zoomed-in. Especially right after pressing the middle mouse button.

When a photo zoom is restored to default (second middle click) or just made smaller than screen-fit size (Ctrl + Wheel Down) the behavior of on-screen controls should remain as it is currently (instantly visible with fade timeout).

Describe alternatives you've considered

There is another possible way to hide all interactive controls: by implementing a dedicated button that will toggle them.

For example, it could be a square labeled "i" ('information' icon), located in top-left corner of this overlay, just like 'X' button is located at tor-right corner currently.

By default after restart of Telegram Desktop client, the state of overlay should be globally visible. This 'i'-button will be visible too (and will fade-out just like other buttons).

When clicked, all of other buttons, links and texts on overlay should disappear, but only this button ought to stay on screen (semi-transparent like 'X'-close) and continue to conform the 3-sec timeout (so eventually it will fade-out, but mouse move will restore it).

Second click on 'i'-button will toggle display of overlay back. The state of overlay visibility should be kept global (for all images and chars) until Telegram Desktop restarts.

When main buttons on overlay are hidden, the image viewer should still accept any keyboard shortcuts to navigate: for example, Left/Right arrow to open next photo, Ctrl+S to save, and Escape to exit picture view mode.

Another possibility would be a context menu entry for image overlay, titled "Hide controls" initially, but "Show controls" when this function was already used to hide the overlay.

Configuration

Operating system: Windows 7 SP1
Version of Telegram Desktop: 2.1.6
Used theme: Day

Additional context

Here are some screenshots of the issue: (with 125% interface scale)

photo with description:

Initial:
description - initial

Default:
description - default
(Note that semi-transparent box with description text and links could still severely interfere with image content)

Timeout:
description - timeout
(And you should hold your mouse very still, to be able to read it like this)

photo albums:

Initial:
album - initial

Default:
album - default
(Note that almost opaque album previews also interfere with content)

Zoomed to the bottom:
album - zoomed
(The main issue: even after zooming in picture manually, this unnecessary overlay still visible)

So it would be very logically to hide overlays on zoom, since if user had zoomed – then he want to see a part of image, and not the text/album previews, which should become visible again after zooming out.

@stale
Copy link

stale bot commented Oct 23, 2020

Hey there!

This issue will be automatically closed in 7 days if there would be no activity. We therefore assume that the user has lost interest or resolved the problem on their own.

Don't worry though; if this is an error, let us know with a comment and we'll be happy to reopen the issue.

Thanks!

@stale stale bot added the stale label Oct 23, 2020
@aleksusklim
Copy link
Author

Э, я те сча закрою, ага!

@stale
Copy link

stale bot commented May 8, 2021

Hey there!

This issue was inactive for a long time and will be automatically closed in 30 days if there isn't any further activity. We therefore assume that the user has lost interest or resolved the problem on their own.

Don't worry though; if this is an error, let us know with a comment and we'll be happy to reopen the issue.

Thanks!

@stale stale bot added the stale label May 8, 2021
@aleksusklim
Copy link
Author

Брысь!

Telegram Desktop 2.7.4, issue still relevant.

@stale stale bot removed the stale label May 8, 2021
@john-preston
Copy link
Member

I'd accept a PR for that one.

aleksusklim added a commit to aleksusklim/tdesktop that referenced this issue May 8, 2021
aleksusklim added a commit to aleksusklim/tdesktop that referenced this issue May 10, 2021
@aleksusklim
Copy link
Author

Done, #16303

aleksusklim added a commit to aleksusklim/tdesktop that referenced this issue May 11, 2021
…time much shorter if the image was zoomed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants