Notification does not appear if Video is full screen

[programcoder]

Notification (in windows) does not appear if Video is full screen. Any video regardless of any player Flash video, Youtube video, VLC player video.

It USED TO appear over videos before the last update.

[auchri]

Notifications doesn't appear any more if a fullscreen application is running, because it's sometime annoying (when playing a game or something like this)

[Aokromes]

So, this PR is no longer needed?
#376
Maybe someone wanna have it as setting.

[auchri]

I think that the pull request can be deleted.

I agree with you, a setting would be fine.

[brynthomas]

@Aokromes My pull request did NOT block full screen notifications from apps like full screen Chrome, VLC, PowerPoint etc. I explicitly tested it and changed the way it worked so that those would still go through, so that having the setting was less necessary. Only D3D Full Screen games would be blocked, as those were the ones that worked poorly with notifications anyway, where clicking on it would force a screen resolution switch.

(i.e. there's a different flag set for full screen for games like @auchri talks about, as this was my issue with Telegram, vs other full screen apps)

[brynthomas]

Just as a follow up, the code for notification suppression is doing the following check:

(state == QUNS_PRESENTATION_MODE || state == QUNS_RUNNING_D3D_FULL_SCREEN || state == QUNS_BUSY)

That last one, checking if state is QUNS_BUSY, causes it to overaggressively filter notifications for anything that behaves even slightly full-screenish. Taking that one out would make it work a lot nicer.

[Aokromes]

@brynthomas ok :) i had the idea of some change made your PR no longer needed :)

[brynthomas]

@Aokromes Yup, the changes are pretty much what was in the pull request, so yeah it can be closed. Just wanted to push for the notification suppression to be less aggressive as with the version in the PR. I think it's better to err on the side of showing notifications, and only to hide them when you're in an app where clicking them could potentially happen accidentally or crash the app you're in (as with full screen games).

Having this current behaviour on a toggle in the settings menu would be a bit annoying, because I'd have to keep turning it on and off. I wouldn't want it to hide notifications when using VLC/Youtube/Twitch, but then I'd have to remember to switch it before and after playing a game.

I still made it play the notification bong when in game so you'd know someone was trying to contact you even if you couldn't see it, I'm not sure if that carried through in the live version.

[auchri]

@brynthomas the notification sound is playing even if a fullscreen application is running.

[programcoder]

Well, too bad its a pain to build Telegram desktop on windows considering, I merely have Visual studio Express, which does not support Qt add-on and I am yet to figure out how to make it work with only Qt creator or so otherwise I have removed that QUNS_BUSY on my own.

well, Hopefully they get rid of it for videos or anything that does not change resolution, or just add a setting that would ask whether you want to see notifications in full screen apps or not.

[Aokromes]

@programcoder you can get Visual Studio 2013 community edition for free :)
http://www.visualstudio.com/en-us/news/vs2013-community-vs.aspx

[programcoder]

Thanks a ton, wasn't aware about that. Been using Express ever since 2008 Express :p
Well, I just hope that they do it in official repo, either setting or just allowing Video over notification.

But setting would be most preferable.

[programcoder]

@Aokromes Thank you very much, I have built the telegram with removed notification condition successfully :) 👍

[telegramdesktop]

Thanks, I will remove QUNS_BUSY in the next version. I've read the docs on that and it told me to suppress notifications in busy too =(

[programcoder]

@telegramdesktop I have already done that in my build, but just removing that does not help it to appear over video's played using VLC etc. you also need to remove QUNS_RUNNING_D3D_FULL_SCREEN for that

I would rather suggest creating a GUI setting for that, for those who need it off or on.

that is, usually people would prefer a notification to appear on video, but would not over a game or something, so they can just do that using that particular setting, please implement if possible.

[auchri]

@telegramdesktop please readd QUNS_BUSY, I don't want notifications while watching YouTube videos :(

[programcoder]

@auchri That's why I said, Make it a GUI setting

[Aokromes]

Or 2, one for D3D / OpenGL (games) and another for QUNS_BUSY

[programcoder]

heh, Owner needs to agree to add GUI option for this, But I do heavily support it.

[auchri]

without QUNS_BUSY the notifications appear over some games, e.g. robocraft

[brynthomas]

@auchri Windows really is such a no-win operating system with APIs like this. There isn't a right answer, you get stuck with two poor options and end up forcing people into toggling settings to get a least-bad setup.

Regarding still seeing it in games, that game is probably running in "borderless" rather than full screen. You can tell a borderless game where you can switch to other apps without having the brief black screen when you switch apps. The D3D_FULL_SCREEN games are the ones where Telegram notifications was a real bug, since it could result in crashes/messed up output/flickering (see Battlefield or Rise of Nations). Borderless games are "just" a pain to have an overlay, or an accidental click on the notification box that switches you out the game.

Guess it comes down to adding options for these things. I hope Windows's Toast system will provider a better way to do this in the future.

[programcoder]

I have added a GUI configuration. I am not sure whether I should make a pull request for it.

I have not added the strings for all languages though, as I am not aware with any of those.

[miva2]

I came here to say I get notifications over fullscreen video and it is very annoying.
So there currently is no way in turning those off in fullscreen only but you guys have been working on a setting? I hope you continue this, it is a very good idea.

[fqdb]

So if I understand this correctly, it was explicitly implemented to have notifications appear over for example full screen Powerpoint presentations?

Is there any news on adding the option to toggle this behaviour?

[electricessence]

Hey, when can we get this fixed? It's ruined games I've been playing.

[auchri]

#473 <=> #2290

[ghost]

Hey there!

We're automatically closing this issue since there was no activity in this issue since 365 days ago. We therefore assume that the user has lost interest or resolved the problem on their own. Closed issues that remain inactive for a long period may get automatically locked.

Don't worry though; if this is in error, let us know with a comment and we'll be happy to reopen the issue.

Thanks!

_{(Please note that this is an automated comment.)}

[github-actions]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.