Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump deps #228

Merged
merged 6 commits into from
Feb 15, 2021
Merged

Bump deps #228

merged 6 commits into from
Feb 15, 2021

Conversation

Mephistophiles
Copy link
Contributor

@Mephistophiles Mephistophiles commented Dec 29, 2020

Bumping telegram-bot deps:

  • bump bytes and tokio to 1.0 version (Closes update tokio to 0.3 #220)
  • bump multipart to 0.17 version
  • bump serde-value to 0.7.0 version
  • bump hyper to 0.14 version and hyper-tls to next version

Also this PR enabled reproducible builds via Cargo.lock. This file was used to
track changes in dependencies. If it is unnecessary - tell me and I will
remove restoring Cargo.lock from this patchset.

Blocked on:

@Mephistophiles Mephistophiles force-pushed the master branch 4 times, most recently from b796347 to 529f7e8 Compare December 29, 2020 20:46
@Mephistophiles Mephistophiles marked this pull request as ready for review December 29, 2020 20:58
@rburchell
Copy link

Build fails with features = [ "rustls" ]:

error[E0599]: no function or associated item named new found for struct hyper_rustls::HttpsConnector<_> in the current scope
--> .../.cargo/git/checkouts/telegram-bot-b574c7dcd66d4faf/529f7e8/lib/src/connector/hyper.rs:162:37
|
162 | let connector = HttpsConnector::new();
| ^^^ function or associated item not found in hyper_rustls::HttpsConnector<_>

Doing some quick searching leads me to this.

@Mephistophiles
Copy link
Contributor Author

@rburchell thanks for you review! Fixed!

@mankinskin mankinskin mentioned this pull request Jan 11, 2021
.gitignore Outdated
@@ -1,5 +1,4 @@
target
Cargo.lock
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From https://doc.rust-lang.org/cargo/guide/cargo-toml-vs-cargo-lock.html :

If you’re building a non-end product, such as a rust library that other rust packages will depend on, put Cargo.lock in your .gitignore

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

Copy link

@schoenenberg schoenenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As @bemyak mentioned in his review, please remove the Cargo.lock.

@gahag
Copy link

gahag commented Jan 31, 2021

+1 to this. I have another dependency that uses tokio 1.0, and now my project does not work anymore!

@Mephistophiles
Copy link
Contributor Author

As @bemyak mentioned in his review, please remove the Cargo.lock.

fixed

@bemyak bemyak mentioned this pull request Feb 8, 2021
@red-avtovo
Copy link
Contributor

Can anyone please take a look on it? I would be happy to have these changes in my project

red-avtovo
red-avtovo previously approved these changes Feb 12, 2021
bemyak
bemyak previously approved these changes Feb 12, 2021
Copy link

@bemyak bemyak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this for my project, works flawlessly. The only potential pitfall is if somebody uses hyper-proxy, because it still depends on hyper 0.13 which is incompatible with 0.14, but there is an opened MR: tafia/hyper-proxy#18

@Mephistophiles
Copy link
Contributor Author

While we were waiting, Tokyo 1.2 was released =). I have updated the patchset.

@red-avtovo
Copy link
Contributor

It looks like we can just update our project dependencies to use this branch and do not wait for the merge 😀

@gugahoa gugahoa merged commit 07a9f9a into telegram-rs:master Feb 15, 2021
@gahag
Copy link

gahag commented Feb 15, 2021

Thanks for the great work everybody! Can we have a new release soon, please? Looking forward to switching back to the crates.io version.

@avinassh
Copy link

@gugahoa can you please release this version, as tokio v1 support is needed for me

@canadiannomad
Copy link

For anyone looking, this is pretty much required in your Cargo.toml file to get things working:

telegram-bot = { git = "https://github.com/telegram-rs/telegram-bot.git" }

Not sure why a release hasn't been issued.

@ryanhossain9797
Copy link

I've had to give up and switch to
https://crates.io/crates/frankenstein

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update tokio to 0.3
10 participants