-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump deps #228
Bump deps #228
Conversation
b796347
to
529f7e8
Compare
Build fails with features = [ "rustls" ]:
Doing some quick searching leads me to this. |
@rburchell thanks for you review! Fixed! |
.gitignore
Outdated
@@ -1,5 +1,4 @@ | |||
target | |||
Cargo.lock |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From https://doc.rust-lang.org/cargo/guide/cargo-toml-vs-cargo-lock.html :
If you’re building a non-end product, such as a rust library that other rust packages will depend on, put Cargo.lock in your .gitignore
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As @bemyak mentioned in his review, please remove the Cargo.lock
.
+1 to this. I have another dependency that uses tokio 1.0, and now my project does not work anymore! |
dca018c
to
c438c8c
Compare
fixed |
Can anyone please take a look on it? I would be happy to have these changes in my project |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested this for my project, works flawlessly. The only potential pitfall is if somebody uses hyper-proxy, because it still depends on hyper 0.13 which is incompatible with 0.14, but there is an opened MR: tafia/hyper-proxy#18
d0cf6cf
c438c8c
to
d0cf6cf
Compare
While we were waiting, Tokyo 1.2 was released =). I have updated the patchset. |
It looks like we can just update our project dependencies to use this branch and do not wait for the merge 😀 |
Thanks for the great work everybody! Can we have a new release soon, please? Looking forward to switching back to the crates.io version. |
@gugahoa can you please release this version, as tokio v1 support is needed for me |
For anyone looking, this is pretty much required in your Cargo.toml file to get things working:
Not sure why a release hasn't been issued. |
I've had to give up and switch to |
Bumping telegram-bot deps:
Also this PR enabled reproducible builds via Cargo.lock. This file was used to
track changes in dependencies. If it is unnecessary - tell me and I will
remove restoring Cargo.lock from this patchset.
Blocked on: