Device provisioning using NGSIv2 #126
Conversation
…2m-iotagent into task/ngsiv2ContextAvailability
dcalvoalonso
changed the title
|
Something interesting is that we have had to modify https://github.com/telefonicaid/lightweightm2m-iotagent/pull/126/files#diff-3e621782cff25b26014cd6896517f873 since in NGSIv2 attributes' names cannot include spaces. This is a problem with this agent since attributes can be imported from https://github.com/telefonicaid/lightweightm2m-iotagent/blob/master/omaRegistry.json and almost any attribute's name contains spaces... |
What about URL scaping? E.g: LWM2M Server URI -< LWM2M%20Server%20URI a bit ugly, but will complian with NGSIv2 rules for attribute names... |
| @@ -188,10 +188,20 @@ function addUnsupportedAttributes(payload, configuration, deviceInformation, cal | |||
| if (omaRegistry[value.objectType].resources) { | |||
There was a problem hiding this comment.
Fixed in b17a3d4
| type: 'string' | ||
| }); | ||
|
|
||
| // In NGSIv2, spaces cannot be used in attributes' names. Therefore, we trim them. |
There was a problem hiding this comment.
Why this problem has arised when developing the NGSIv2-based provisioning but not in the previous NGSIv2-based active attributes values sending?
Or the situation was the same and also the same the solution applied (i.e. trim spaces)?
There was a problem hiding this comment.
Because there is not any test as part of iotagent-node-lib, iotagent-ul or iotagent-json that contains spaces in the attributes' names... Maybe it is something that we must solve at iotagent-node-lib level?
There was a problem hiding this comment.
If this something common to all the agents, iotagent-node-lib seems a good place to cover it with tests.
There was a problem hiding this comment.
I have been doing some tests regarding this issue and it is more complicated than it seemed initially.
If we decide that iotagent-node-lib will escape spaces in device's attributes automatically, this change may imply a big amount of work since it affects to device provisioning, forwarding of active attributes, plugins...
In my eyes, the best solution is:
- At iotagen-node-lib level, to follow the same approach as in Orion CB and reject device provisioning requests that attributes' names with spaces.
- At lightweightm2m-iotagent, since https://github.com/telefonicaid/lightweightm2m-iotagent/blob/master/omaRegistry.json contains a lot of spaces, we could implement space escaping.
There was a problem hiding this comment.
Just to check if I'm understanding correctly...
You mean not touching iotagent-node-lib and implement space adaptation in the agent code itself? (either removing it as the PR shows now or apply %20 escaping). Is that correct?
There was a problem hiding this comment.
Yes, that's correct. I agree with you to implementing %20 escaping but just in this specific IOTA. Implementing this in the iotagent-node-lib would be a very big effort and the benefit is very small...
There was a problem hiding this comment.
I agree. So the idea is to change the current mechanism in this PR (removing spaces) to the new one (escaping spaces using %20)?
There was a problem hiding this comment.
Yes, I will implement this ASAP. :)
There was a problem hiding this comment.
Fixed in 9eadfbb
|
Is the issue created at Orion repository (telefonicaid/fiware-orion#3238) related with this PR? I mean, does that issue be debugged and eventually solved before merging this PR? |
|
No, to avoid dependencies with telefonicaid/fiware-orion#3238, I have done a little workaround in https://github.com/dcalvoalonso/lightweightm2m-iotagent/blob/task/ngsiv2ContextAvailability/test/unit/ngsiv2/registration-test.js#297: to query the whole entity. :) |
CHANGES_NEXT_RELEASE
Outdated
| @@ -16,3 +16,4 @@ | |||
| - Fix: first observable value is processed and forwarded to the CB (#73). | |||
| - Add: allow NGSIv2 for updating active attributes at CB, through configuration (#104) | |||
| - Using precise dependencies (~=) in packages.json | |||
| - Add: supports NGSIv2 for device provisioning (entity creation and context registration) at CB (#233) | |||
| type: 'string' | ||
| }); | ||
|
|
||
| // In NGSIv2, spaces cannot be used in attributes' names. Therefore, we trim them. |
There was a problem hiding this comment.
Taking into account how it has been implemented at the end, I understand "... Therefore, we trim them" should be changed.
There was a problem hiding this comment.
Fixed with 0196c46
|
As always, @fgalan thanks for your comments and detailed review, I really appreciate them! :) We will wait for the results of the e2e tests in order to finish the PR and merge into master. |
…2m-iotagent into task/ngsiv2ContextAvailability
|
LGTM to changes 0196c46...a00bf45 |
This PR implements device provisioning using NGSIv2.
After the LGTM to telefonicaid/iotagent-node-lib#615 and the merge of telefonicaid/fiware-orion#3217. We can pass the tests against the CB.