Bug/693 ontimeinterval subscription recovery #697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
| static void destroyOnTimeIntervalThread(std::string tenant, BSONObj* subP) | ||
| { | ||
| BSONElement idField = subP->getField("_id"); | ||
| std::string subId = idField.OID().str(); |
There was a problem hiding this comment.
Why not apply "Paranoia check (I)" also in that place for subId?
There was a problem hiding this comment.
Well, those checks were there already and I decided to let them stay.
I can put one in here too if you want :-) (probably not necessary but it doesn't hurt)
|
LGTM |
fgalan
pushed a commit
that referenced
this pull request
Jan 5, 2015
…cription_recovery Bug/693 ontimeinterval subscription recovery
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the bug of issue #693.
This fix will probably also solve the mysterious case of 'false leaks' we've been seeing (and trying to fix).
Instead of creating a vector of subscriptions, a callback function (treating the subscription) is sent to the function that loops over the subscriptions.
The bug in the previous implementation was that the vector got corrupted as soon as the function that created the vector finished (symptom telling us we had stuff on the stack - in this case the BSON objects inside the vector).