Fixed RPM package so PID file is stored in /var/run/contextBroker #662
Conversation
…ad of /var/log/contextBroker.
| @@ -103,7 +105,8 @@ cp -R %{_sourcedir}/etc $RPM_BUILD_ROOT | |||
| # it as part of our install script | |||
| strip $RPM_BUILD_ROOT/usr/bin/contextBroker | |||
| chmod 555 $RPM_BUILD_ROOT/usr/bin/contextBroker | |||
| mkdir -p $RPM_BUILD_ROOT/var/%{name} | |||
| #FIXME: I think next line is not actually needed, thus it has been commented out for a quarentine period (starting on 24/11/2014) | |||
| #mkdir -p $RPM_BUILD_ROOT/var/%{name} | |||
There was a problem hiding this comment.
Not sure why this line was there, but it seems it has no effect. As far as I understand, it would create the "/var/contextBroker" directory but, after installing package, such directory doesn't exist:
[fermin@centollo fiware-orion]$ ls /var/contextBroker
ls: no se puede acceder a /var/contextBroker: No existe el fichero o el directorio
Thus, probably this lines has no effect. Anway, it's weird.
There was a problem hiding this comment.
And I don't really understand the need for such directory, so I think is a good idea to remove it.
There was a problem hiding this comment.
Ok, let's have the line commented for a while, then remove it permanently after a while.
NTC
| @@ -72,7 +72,9 @@ exit 0 | |||
| DATE=$(date "+%Y-%m-%d") | |||
| /sbin/chkconfig --add %{name} | |||
| mkdir -p /var/log/%{name} | |||
| mkdir -p /var/run/%{name} | |||
There was a problem hiding this comment.
Here you are creating the /var/runn/contextBroker folder, but you are leaving the contextBroker.pid file in /var/run/contextBroker.pid. Did you do that intentionally?
There was a problem hiding this comment.
That's is done at etc/config/contextBroker file:
BROKER_PID_FILE=/var/run/contextBroker.pid
Conflicts: CHANGES_NEXT_RELEASE
|
LGTM |
Fixed RPM package so PID file is stored in /var/run/contextBroker
Implements #612