Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX GET /v2/types and GET /v2/types/{type} wrong attribute types result #4217

Merged
merged 1 commit into from
Sep 28, 2022
Merged

FIX GET /v2/types and GET /v2/types/{type} wrong attribute types result #4217

merged 1 commit into from
Sep 28, 2022

Conversation

fgalan
Copy link
Member

@fgalan fgalan commented Sep 28, 2022

@fgalan fgalan mentioned this pull request Sep 28, 2022
Closed
@fgalan fgalan requested a review from mapedraza September 28, 2022 14:05
mapedraza
mapedraza approved these changes Sep 28, 2022
View reviewed changes
Copy link
Collaborator

@mapedraza mapedraza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mapedraza mapedraza merged commit 7b45e6e into master Sep 28, 2022
@mapedraza mapedraza deleted the bug/4216 branch September 28, 2022 14:32
@ArqamFarooqui110719
Copy link
Contributor

There is a Typo at Line#38 in FT file.

 # 06. GET /v2/types/ET1 and get AT3 and AT4 attribute types

It should be:

# 06. GET /v2/types/ET1 and get AT1 and AT2 attribute types

@fgalan
Copy link
Member Author

fgalan commented Oct 3, 2022 •
edited
Loading

There is a Typo at Line#38 in FT file.

# 06. GET /v2/types/ET1 and get AT3 and AT4 attribute types

It should be:

# 06. GET /v2/types/ET1 and get AT1 and AT2 attribute types

Fixed in PR #4219. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mapedraza mapedraza mapedraza approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fgalan @ArqamFarooqui110719 @mapedraza