Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADD service, servicePath and authToken macros to custom notifications #4166

Merged
merged 4 commits into from
Jul 12, 2022

Conversation

fgalan
Copy link
Member

@fgalan fgalan commented Jul 8, 2022

Issue #4159

  • attribute overrides
  • documentation
  • CNR

@fgalan fgalan changed the title [WIP] ADD service, servicePath and authToken macros to custom notifications ADD service, servicePath and authToken macros to custom notifications Jul 11, 2022
@fgalan fgalan requested a review from mapedraza July 11, 2022 13:12
Copy link
Collaborator

@mapedraza mapedraza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mapedraza mapedraza merged commit c6fef64 into master Jul 12, 2022
@mapedraza mapedraza deleted the feature/4159_extra_custom_notif_macros branch July 12, 2022 08:55
@fgalan
Copy link
Member Author

fgalan commented Jul 12, 2022

@fisuda this PR does some modifications to the .md documentation. It would be great if you could sync the Japanese translation, please. Thanks!

fisuda added a commit to fisuda/fiware-orion that referenced this pull request Jul 12, 2022
@fisuda
Copy link
Contributor

fisuda commented Jul 12, 2022

I sent the PR #4169.

fgalan added a commit that referenced this pull request Jul 12, 2022
(JP) ADD doc about custom notification extra macro (#4166)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants