-
Notifications
You must be signed in to change notification settings - Fork 265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix using limit=0 and details=on to get only the count of elements (prelanding) #4104
Conversation
Conflicts: CHANGES_NEXT_RELEASE
Fix using limit=0 and details=on to get only the count of elements #1492
"code": "400", | ||
"details": "Bad pagination limit: /000000/ [a value of ZERO is unacceptable]", | ||
"details": "JSON Parse Error", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I finally found the reason for this "JSON Parse Error" :)
payload='NO PAYLOAD NECESSARY'
Let's try to modify this tests with a proper queryContext JSON request payload...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in ae956ec
I have simplified the code so for instance instead of
we have a more compact equivalent option:
to avoid unnecessary re-indentation of code blocks. |
Please @Anjali-NEC have a look to the final state of this PR and if you find it ok provide LGTM so we can merge it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
LGTM |
Continues the work in PR #3994 . Issue #1492
Note that just after creating the PR (at commit c20bd31) the diff is +707 -62 deletions, exactly as in the original PR.
CC: @Anjali-NEC . Please pay attention to any further comment or modification I'll do in this PR.