-
Notifications
You must be signed in to change notification settings - Fork 265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix a crash & add ftest to cover other reported cases #3615
Fix a crash & add ftest to cover other reported cases #3615
Conversation
Did you have a chance to do the checking, please? Thanks! |
Update: with regards to #3607 this new commit caeb5dd adds a test case covering the cases (test/functionalTest/cases/3607_killer_request_apiv1/killer_request_apiv1_parsing_cases.test). As you can see, I'm being unable to reproduce the crash based in the inputs provided in that issue and what I get for each one of the three requests is an NGSI-v1 style error message:
Mabye something is wrong in the added .test? It would be great if @0xricksanchez could have a look please? With regards to the other issue, I'm still waiting for clarification, see #3609 (comment) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@fisuda this PR includes a small addition to one of the .md documentation files. It would be great if you could sync the Japanese translation. Thanks! |
Noted with thanks! |
(JP) Add documentation of Maximum nesting level. (#3615)
This PR:
@0xricksanchez it would be great if you could have a look to the .test in this PR to ensure they cover the cases you reported in the issues, pls. Thanks!