Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a crash & add ftest to cover other reported cases #3615

Merged
merged 10 commits into from
Mar 20, 2020

Conversation

fgalan
Copy link
Member

@fgalan fgalan commented Jan 29, 2020

This PR:

@0xricksanchez it would be great if you could have a look to the .test in this PR to ensure they cover the cases you reported in the issues, pls. Thanks!

@fgalan
Copy link
Member Author

fgalan commented Mar 17, 2020

@0xricksanchez it would be great if you could have a look to the .test in this PR to ensure they cover the cases you reported in the issues, pls. Thanks!

Did you have a chance to do the checking, please?

Thanks!

@fgalan
Copy link
Member Author

fgalan commented Mar 17, 2020

Update: with regards to #3607 this new commit caeb5dd adds a test case covering the cases (test/functionalTest/cases/3607_killer_request_apiv1/killer_request_apiv1_parsing_cases.test). As you can see, I'm being unable to reproduce the crash based in the inputs provided in that issue and what I get for each one of the three requests is an NGSI-v1 style error message:

{
    "errorCode": {
        "code": "400",
        "details": "JSON Parse Error",
        "reasonPhrase": "Bad Request"
    }
}

Mabye something is wrong in the added .test? It would be great if @0xricksanchez could have a look please?

With regards to the other issue, I'm still waiting for clarification, see #3609 (comment)

@fgalan fgalan changed the title [WIP] Fix crash & add ftest to cover other reported cases Fix a crash & add ftest to cover other reported cases Mar 19, 2020
@fgalan
Copy link
Member Author

fgalan commented Mar 20, 2020

Recent commits in 9d8775d and fbb27c4 implement and maximum nesting limit (50 levels) so the 500 Internal Error due to MongoDB error is now transformed in a 400 Bad Request message with informative message.

Copy link
Member

@AlvaroVega AlvaroVega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlvaroVega AlvaroVega merged commit 9bd8525 into master Mar 20, 2020
@AlvaroVega AlvaroVega deleted the hardening/3603_3604_3605_3606_3607_3608_3609 branch March 20, 2020 12:03
@fgalan
Copy link
Member Author

fgalan commented Mar 20, 2020

@fisuda this PR includes a small addition to one of the .md documentation files. It would be great if you could sync the Japanese translation. Thanks!

@fisuda
Copy link
Contributor

fisuda commented Mar 20, 2020

Noted with thanks!

fisuda added a commit to fisuda/fiware-orion that referenced this pull request Mar 20, 2020
fgalan added a commit that referenced this pull request Mar 23, 2020
(JP) Add documentation of Maximum nesting level. (#3615)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants