-
Notifications
You must be signed in to change notification settings - Fork 265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX error responses section in NGSIv2 spec #3226
FIX error responses section in NGSIv2 spec #3226
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, with the points raised addressed
|
||
New error codes may be defined in new iterations of this specification. | ||
|
||
All NGSIv2 server implementations must use the following HTTP response codes and `error` texts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
HTTP status codes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in adac43d
|
||
NGSIv2 `error` reporting is as follows: | ||
|
||
+ If the incoming JSON payload cannot be parsed then `ParseError` (`400`) is return. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
returned
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in adac43d
NGSIv2 `error` reporting is as follows: | ||
|
||
+ If the incoming JSON payload cannot be parsed then `ParseError` (`400`) is return. | ||
+ Request error which only depends on the request itself (i.e. it does not depend on the NGSIv2 server status), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Errors which are only caused by request content
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in adac43d
+ Exception: incoming JSON payload errors, which have another `error` message (see previous bullet). | ||
+ Attemp to exceed spatial index limit results in `NoResourceAvailable` (`413`). See "Geospatial properties of entities" | ||
section for details. | ||
+ Ambiguety due to the request may refer to several resources, e.g. attempt to update an entity providing only its ID |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
check spelling
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in adac43d
Section "Error responses" has been re-written, based on #1286 explaining with more detail how error are generated in NGSIv2.
I suggest not ussing diff at github, which is pretty confusing, but to read the new version directly.