Bug/1849 attribute values and multiple accept types #2323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -30,3 +30,4 @@ | |||
| - Fix: Avoid rendering at the same time id and idPattern fields in NGSIv2 subscriptions | |||
| - Fix: Error returned on GET/DELETE requests specifying Content-Type (Issue #2128) | |||
| - Fix: Error responses with '405 Method Not Allowed' now return payload to describe the error, for v2 requests only (Issue #2075, #2078 and #2083) | |||
| - Fix: Implemented more sofisticated HTTP Accept Header handling (Issue #1849) | |||
There was a problem hiding this comment.
The five issue numbers solved by this PR should be mentioned.
In addition, not sure about "more sofisticated" is the best alternative... It is not about sofistication, but about correctness or accuracy.
|
LGTM |
This was referenced Jul 6, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issues #1037, #1849, #1886, #2175, and #2208